You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/09/30 19:02:34 UTC
Review Request 38899: Added handler for Executor->Framework message
for the Executor HTTP API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/
-----------------------------------------------------------
Review request for mesos, Isabel Jimenez and Vinod Kone.
Bugs: MESOS-2296
https://issues.apache.org/jira/browse/MESOS-2296
Repository: mesos
Description
-------
Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
Diffs
-----
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
Diff: https://reviews.apache.org/r/38899/diff/
Testing
-------
make check. Would add tests later after the MESOS-3480 review chain gets committed.
Thanks,
Anand Mazumdar
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Oct. 4, 2015, 7:30 a.m., Guangya Liu wrote:
> > src/slave/http.cpp, line 316
> > <https://reviews.apache.org/r/38899/diff/1/?file=1087826#file1087826line316>
> >
> > I think that the blank line is not needed.
It's always considered good practice to have a newline after a multiline continuation statement.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101439
-----------------------------------------------------------
On Sept. 30, 2015, 5:02 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Bugs: MESOS-2296
> https://issues.apache.org/jira/browse/MESOS-2296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101439
-----------------------------------------------------------
src/slave/http.cpp (line 316)
<https://reviews.apache.org/r/38899/#comment158829>
I think that the blank line is not needed.
- Guangya Liu
On 九月 30, 2015, 5:02 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated 九月 30, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Bugs: MESOS-2296
> https://issues.apache.org/jira/browse/MESOS-2296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101137
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38899]
All tests passed.
- Mesos ReviewBot
On Sept. 30, 2015, 5:02 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2015, 5:02 p.m.)
>
>
> Review request for mesos, Isabel Jimenez and Vinod Kone.
>
>
> Bugs: MESOS-2296
> https://issues.apache.org/jira/browse/MESOS-2296
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
> On Oct. 7, 2015, 6:40 p.m., Isabel Jimenez wrote:
> > Ship It!
LGTM, just might need to get rebase on changes for switch syntax in other patches.
- Isabel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101805
-----------------------------------------------------------
On Oct. 7, 2015, 6:39 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 6:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2295
> https://issues.apache.org/jira/browse/MESOS-2295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101805
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 7, 2015, 6:39 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated Oct. 7, 2015, 6:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2295
> https://issues.apache.org/jira/browse/MESOS-2295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review108380
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 30, 2015, 5:01 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2015, 5:01 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2295
> https://issues.apache.org/jira/browse/MESOS-2295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp c3247f17e9faed32a46d3ab9ee83c399cd2c8d5e
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 5:01 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Rebased
Bugs: MESOS-2295
https://issues.apache.org/jira/browse/MESOS-2295
Repository: mesos
Description
-------
Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
Diffs (updated)
-----
src/slave/http.cpp c3247f17e9faed32a46d3ab9ee83c399cd2c8d5e
Diff: https://reviews.apache.org/r/38899/diff/
Testing
-------
make check. Would add tests later after the MESOS-3480 review chain gets committed.
Thanks,
Anand Mazumdar
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/#review101862
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 7, 2015, 6:39 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38899/
> -----------------------------------------------------------
>
> (Updated 十月 7, 2015, 6:39 p.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Bugs: MESOS-2295
> https://issues.apache.org/jira/browse/MESOS-2295
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
>
>
> Diffs
> -----
>
> src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
>
> Diff: https://reviews.apache.org/r/38899/diff/
>
>
> Testing
> -------
>
> make check. Would add tests later after the MESOS-3480 review chain gets committed.
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 38899: Added handler for Executor->Framework
message for the Executor HTTP API
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38899/
-----------------------------------------------------------
(Updated Oct. 7, 2015, 6:39 p.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Updated Bugs section to link to MESOS-2295 as it is around getting the `api/v1/executor` endpoint to work correctly.
Bugs: MESOS-2295
https://issues.apache.org/jira/browse/MESOS-2295
Repository: mesos
Description
-------
Trivial change to call the `executorMessage(...)` function that already existed in `src/slave/slave.cpp` to handle ExecutorToFrameworkMessage.
Diffs
-----
src/slave/http.cpp f9cf7bbe81b7fe9637de9a8d66329c16a7e1a89b
Diff: https://reviews.apache.org/r/38899/diff/
Testing
-------
make check. Would add tests later after the MESOS-3480 review chain gets committed.
Thanks,
Anand Mazumdar