You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/30 13:55:47 UTC

[GitHub] [incubator-nuttx-apps] v01d opened a new pull request #641: mqttc example: provide sane hostname default to avoid crash

v01d opened a new pull request #641:
URL: https://github.com/apache/incubator-nuttx-apps/pull/641


   ## Summary
   
   Provide a sane hostname default (I used a public test broker for convenience). Otherwise it results in a crash since the
   hostname variable was uninitialized. I also made slight improvements to output.
   
   ## Impact
   
   Fix potential crash in example app.
   
   ## Testing
   
   esp32-devkitc:wapi
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #641: mqttc example: provide sane hostname default to avoid crash

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #641:
URL: https://github.com/apache/incubator-nuttx-apps/pull/641#issuecomment-810285883


   I forgot to include the README change. I just force pushed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #641: mqttc example: provide sane hostname default to avoid crash

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #641:
URL: https://github.com/apache/incubator-nuttx-apps/pull/641


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] davids5 commented on pull request #641: mqttc example: provide sane hostname default to avoid crash

Posted by GitBox <gi...@apache.org>.
davids5 commented on pull request #641:
URL: https://github.com/apache/incubator-nuttx-apps/pull/641#issuecomment-810283733


   > I've included the change in #640 . If it gets merged before this, it should be able to be rebased easily.
   
   I do not see it in #640 - did you force push it yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] v01d commented on pull request #641: mqttc example: provide sane hostname default to avoid crash

Posted by GitBox <gi...@apache.org>.
v01d commented on pull request #641:
URL: https://github.com/apache/incubator-nuttx-apps/pull/641#issuecomment-810274414


   I've included the change in #640 . If it gets merged before this, it should be able to be rebased easily.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org