You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ofbiz.apache.org by "Adrian Crum (JIRA)" <ji...@apache.org> on 2009/04/23 20:43:30 UTC

[jira] Commented: (OFBIZ-2349) Allow HTML Characters in UILabels

    [ https://issues.apache.org/jira/browse/OFBIZ-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702052#action_12702052 ] 

Adrian Crum commented on OFBIZ-2349:
------------------------------------

I don't think this is a good approach. If any transformations need to be done to a UI label, they should be done by the renderer. Keep in mind that UI labels are used for things other than HTML display.

Btw, the if (value != null && (value instanceof String)) code block isn't necessary - that was already handled in the previous try-catch block.




> Allow HTML Characters in UILabels
> ---------------------------------
>
>                 Key: OFBIZ-2349
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2349
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Andrew Zeneski
>            Assignee: Andrew Zeneski
>            Priority: Minor
>             Fix For: SVN trunk
>
>         Attachments: WrapResourceMap.patch
>
>
> In response the the thread on dev@ofbiz.apache.org (Re: &#160; Codes) the included patch resolves the issue of ignoring HTML in UILabel values, by using the StringUtil.wrapString() method to wrap all resource values. This was not checked in due to the fact I am not sure what the overall effect will be and may break code which I did not test. It may also violate the new security policies.
> The patch is here until it can be determined valid or not.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.