You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/12 20:00:34 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on pull request #4103: LTP: fix stacke overflow in ltp_interfaces_pthread_attr_setstacksize_1_1

gustavonihei commented on pull request #4103:
URL: https://github.com/apache/incubator-nuttx/pull/4103#issuecomment-878238071


   I am not sure whether this change is a good thing. But one thing that concerns me is that both the MIN and DEFAULT stack size values for a pthread are now the same.
   
   > BTW, DEFAULT_TASK_STACKSIZE is a reasonable default value for PTHREAD_STACK_MIN because DEFAULT_TASK_STACKSIZE is designed to as a safe minial value for the target platform.
   
   I don't have data to support my argument, but I believe that the DEFAULT stack size should have a growth margin above the minimum value, while still maintaining the safe characteristic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org