You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/23 06:40:37 UTC
[GitHub] [doris] carlvinhust2012 opened a new pull request, #10173: [opt] delete the redundant parameter of _execute_non_nullable
carlvinhust2012 opened a new pull request, #10173:
URL: https://github.com/apache/doris/pull/10173
# Proposed changes
1. This pr is used to delete the redundant parameter of _execute_non_nullable.
2. This modification will not affect the function "element_at".
Issue Number: close #xxx
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (No)
4. Has unit tests been added: (No Need)
5. Has document been added or modified: (No Need)
6. Does it need to update dependencies: (No)
7. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10173:
URL: https://github.com/apache/doris/pull/10173#issuecomment-1164012790
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 commented on PR #10173:
URL: https://github.com/apache/doris/pull/10173#issuecomment-1165138400
> Hi @carlvinhust2012 please rebase the code to trigger the checks again
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] carlvinhust2012 closed pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
carlvinhust2012 closed pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
URL: https://github.com/apache/doris/pull/10173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #10173:
URL: https://github.com/apache/incubator-doris/pull/10173#issuecomment-1158548086
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #10173:
URL: https://github.com/apache/doris/pull/10173#issuecomment-1163988398
Hi @carlvinhust2012 please rebase the code to trigger the checks again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10173:
URL: https://github.com/apache/incubator-doris/pull/10173#issuecomment-1158654795
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10173:
URL: https://github.com/apache/incubator-doris/pull/10173#issuecomment-1158654829
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #10173:
URL: https://github.com/apache/doris/pull/10173#issuecomment-1165477421
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #10173: [opt] delete the redundant parameter of _execute_non_nullable
Posted by GitBox <gi...@apache.org>.
morningman merged PR #10173:
URL: https://github.com/apache/doris/pull/10173
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org