You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tez.apache.org by GitBox <gi...@apache.org> on 2021/02/10 18:53:09 UTC

[GitHub] [tez] belugabehr commented on pull request #95: TEZ-4275: Use Google Guava Intern Facility

belugabehr commented on pull request #95:
URL: https://github.com/apache/tez/pull/95#issuecomment-776932876


   OK @jteagles @abstractdog this PR is failing on some pre-existing find bugs error.  Kind of funny actually:
   
   
   ```
   Null passed for non-null parameter of com.google.common.base.Strings.isNullOrEmpty(String)
   ```
   
   The method has `isNull` in the name of it, of course it can accept a null value. :D
   
   Please consider these changes as they should lower memory requirements, provide faster concurrent access, and simplify the code a bit.  In particular, please consider my thoughts here:
   
   https://github.com/apache/tez/pull/95#discussion_r572336225


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org