You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Antonio Sanso (JIRA)" <ji...@apache.org> on 2012/10/26 14:45:12 UTC
[jira] [Created] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Antonio Sanso created SLING-2635:
------------------------------------
Summary: [Tooling] Logging framework for Slingclipse
Key: SLING-2635
URL: https://issues.apache.org/jira/browse/SLING-2635
Project: Sling
Issue Type: Sub-task
Reporter: Antonio Sanso
We need a Logging framework for Slingclipse.
I see two options at the moment:
- using a log framework as SLF4J logger or other similar
- using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484911#comment-13484911 ]
Robert Munteanu commented on SLING-2635:
----------------------------------------
m2e has a logback feature which bridges to the Eclipse error log but I'm not sure how reusable it is
http://git.eclipse.org/c/m2e/m2e-core.git/tree/ - org.eclipse.m2e.logback.{appender,configuration,feature)
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487710#comment-13487710 ]
Antonio Sanso commented on SLING-2635:
--------------------------------------
Thanks for your patch Robert! I have applied it in revision 1404111.
So we will use the Eclipse logging facilities going forward (at least for now).
Would it makes sense to create a wrapper class in case we change our mind?
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Sanso reassigned SLING-2635:
------------------------------------
Assignee: Antonio Sanso
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487650#comment-13487650 ]
Robert Munteanu commented on SLING-2635:
----------------------------------------
This patch replaces the e.printStackTrace() call with a Eclipse logger. Since we are inside a Eclipse-invoked listener it's natural to use the Eclipse logging facilities, at least for now.
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Antonio Sanso (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484918#comment-13484918 ]
Antonio Sanso commented on SLING-2635:
--------------------------------------
adding blog article about embedded eclipse logging http://www.jumpingbean.co.za/blogs/mark/eclipse-rcp-logging
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487768#comment-13487768 ]
Robert Munteanu commented on SLING-2635:
----------------------------------------
I think that the most important thing is to have a logging framework in place, no matter how we do it. I have used the m2e wrapper for logback and there are some problems with it.
- You can't enable debug logging or change the logging level without going to a plugin location on disk and modifying logback.properties
- The plugin id in the Eclipse error view will always be the m2e.logback plugin id, not the originating plugin
What I've used with good success is
- The Eclipse ILog object for messages which should be of intereset to the user and end up in the Error Log view.
- The [Eclipse tracing facility|http://wiki.eclipse.org/FAQ_How_do_I_use_the_platform_debug_tracing_facility%3F] for developer-related logs , which can potentially be turned on by the user . For instance, since Eclipse 4.2 there is a [Tracing Preference Page|http://download.eclipse.org/eclipse/downloads/drops4/R-4.2-201206081400/news/eclipse-news-part4.html#TracingPage] which the user can use to activate/deactive tracing for contributing plugins.
As for the non-Eclipse plugins, we should either settle on a well-known logging framework, such as Logback, or simply perform no logging and allow the consumer to provide logging around them. This is what jgit does, and it's embeddable by defintion
- Eclipse
- Netbeans
- Gerrit
Anyway, until we have 5000+ lines of logging infrastructure I think we can defer the decision :-) and focus on more shiny features.
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (SLING-2635) [Tooling] Logging framework
for Slingclipse
Posted by "Dan Klco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487717#comment-13487717 ]
Dan Klco edited comment on SLING-2635 at 10/31/12 12:46 PM:
------------------------------------------------------------
I think it may be cleaner to abstract the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction.
was (Author: klcodanr):
I'd actually recommend abstracting the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction.
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated SLING-2635:
-----------------------------------
Attachment: SLING-2635.diff
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Dan Klco (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487717#comment-13487717 ]
Dan Klco commented on SLING-2635:
---------------------------------
I'd actually recommend abstracting the logging. I can look into creating a SLF4J wrapper for the Plugin's Eclipse logger. That way we can swap out with whatever we'd want if we decide to move in a different direction.
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2635) [Tooling] Logging framework for
Slingclipse
Posted by "Robert Munteanu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487712#comment-13487712 ]
Robert Munteanu commented on SLING-2635:
----------------------------------------
In reply to comment #4:
> So we will use the Eclipse logging facilities going forward (at least for now).
> Would it makes sense to create a wrapper class in case we change our mind?
IMO this isn't worth it in the org.apache.sling.slingclipse bundle since it strongly depends on Eclipse APIs and will always run in Eclipse. However, the api and http bundles should ideally not depend on Eclipse and we might want to make them as independent as possible if we want to reuse them for other environments ( Netbeans, Intellij, CLI ).
> [Tooling] Logging framework for Slingclipse
> -------------------------------------------
>
> Key: SLING-2635
> URL: https://issues.apache.org/jira/browse/SLING-2635
> Project: Sling
> Issue Type: Sub-task
> Components: Extensions
> Reporter: Antonio Sanso
> Assignee: Antonio Sanso
> Attachments: SLING-2635.diff
>
>
> We need a Logging framework for Slingclipse.
> I see two options at the moment:
> - using a log framework as SLF4J logger or other similar
> - using the embedded Eclipse logging framework
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira