[GitHub] [dubbo] zrlw commented on issue #8689: curator_version版本4.0.1存在缺陷

[GitBox <gi...@apache.org>]

zrlw commented on issue #8689:
URL: https://github.com/apache/dubbo/issues/8689#issuecomment-913381735


   看了一眼master分支，用的版本也是4.0.1。
   
   顺便说一下，AbstractClusterInvokerTest这个测试类的下列逻辑有毛病：
   ```
           Double d = (Math.random() * (max - min + 1) + min);
           int runs = d.intValue();
           Assertions.assertTrue(runs > min); 
   ```
   random返回值可以是0的，所以此处断言应该是 >=，恰好github构建时就是0,所以构建失败了。


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org