You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/08/18 14:43:27 UTC
[GitHub] flink pull request #4566: [FLINK-7477] [FLINK-7480] Various improvements to ...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/4566
[FLINK-7477] [FLINK-7480] Various improvements to Flink scripts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink hadoop-env-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4566.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4566
----
commit 6b4d7e5e09dcd913fbb9c84c59fc8a10e6c662cc
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-08-18T14:39:41Z
[FLINK-7477] Use "hadoop classpath" to augment classpath when available
This improves the out-of-box experience on GCE and AWS, both of which
don't set a HADOOP_CLASSPATH but have "hadoop" available on the $PATH.
commit f63e2d03d739014f0cd94634d731e552a02c76d9
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-08-18T14:40:55Z
[FLINK-7480] Set HADOOP_CONF_DIR to sane default if not set
This improves the out-of-box experience on GCE and AWS, both of which
don't set HADOOP_CONF_DIR by default but use /etc/hadoop/conf
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4566: [FLINK-7477] [FLINK-7480] Various improvements to Flink s...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4566
@rmetzger I addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4566: [FLINK-7477] [FLINK-7480] Various improvements to ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4566#discussion_r133985612
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -351,8 +351,20 @@ if [ -z "$HADOOP_CONF_DIR" ]; then
fi
fi
+# try and set HADOOP_CONF_DIR to some common default if it's not set
+if [ -z "$HADOOP_CONF_DIR" ]; then
+ if [ -d "/etc/hadoop/conf" ]; then
+ HADOOP_CONF_DIR="/etc/hadoop/conf"
--- End diff --
I would suggest to print a message to the user that we are using this HADOOP_CONF_DIR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4566: [FLINK-7477] [FLINK-7480] Various improvements to ...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/4566
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4566: [FLINK-7477] [FLINK-7480] Various improvements to Flink s...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/4566
It's a bash command, AFAIK.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4566: [FLINK-7477] [FLINK-7480] Various improvements to ...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/4566#discussion_r133985865
--- Diff: flink-dist/src/main/flink-bin/bin/config.sh ---
@@ -351,8 +351,20 @@ if [ -z "$HADOOP_CONF_DIR" ]; then
fi
fi
+# try and set HADOOP_CONF_DIR to some common default if it's not set
+if [ -z "$HADOOP_CONF_DIR" ]; then
+ if [ -d "/etc/hadoop/conf" ]; then
+ HADOOP_CONF_DIR="/etc/hadoop/conf"
+ fi
+fi
+
INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}"
+# check if the "hadoop" binary is available, if yes, use that to augment the CLASSPATH
+if command -v hadoop >/dev/null 2>&1; then
+ INTERNAL_HADOOP_CLASSPATHS="${HADOOP_CLASSPATH}:${HADOOP_CONF_DIR}:${YARN_CONF_DIR}:`hadoop classpath`"
--- End diff --
I would actually append `INTERNAL_HADOOP_CLASSPATHS` instead of overwriting it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4566: [FLINK-7477] [FLINK-7480] Various improvements to Flink s...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the issue:
https://github.com/apache/flink/pull/4566
+1 to merge (assuming `command` is available on all operating systems / or is a bash command?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---