You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "LemonLiTree (via GitHub)" <gi...@apache.org> on 2023/04/17 03:10:06 UTC
[GitHub] [doris] LemonLiTree opened a new pull request, #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
LemonLiTree opened a new pull request, #18721:
URL: https://github.com/apache/doris/pull/18721
1.
mysql> select ST_AsBinary(st_point(24.7, 56.7));
+----------------------------------------------+
| st_asbinary(st_point(24.7, 56.7)) |
+----------------------------------------------+
| \x01010000003333333333b338409a99999999594c40 |
+----------------------------------------------+
1 row in set (0.01 sec)
2.
Since the S2 library is not based on the WGS-84 coordinate system, it is not correct to construct EWKB format data in 4326, so delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18721:
URL: https://github.com/apache/doris/pull/18721#discussion_r1168166090
##########
be/src/geo/wkb_parse.cpp:
##########
@@ -43,6 +87,36 @@ GeoParseStatus WkbParse::parse_wkb(std::istream& is, bool isEwkb, GeoShape** sha
return ctx.parse_status;
}
+WkbParseContext* WkbParse::read_hex(std::istream& is, WkbParseContext* ctx) {
+ // setup input/output stream
+ std::stringstream os(std::ios_base::binary | std::ios_base::in | std::ios_base::out);
Review Comment:
warning: implicit instantiation of undefined template 'std::basic_stringstream<char>' [clang-diagnostic-error]
```cpp
std::stringstream os(std::ios_base::binary | std::ios_base::in | std::ios_base::out);
^
```
**/usr/include/c++/11/iosfwd:107:** template is declared here
```cpp
class basic_stringstream;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1511119327
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510684140
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 32.49 seconds
stream load tsv: 437 seconds loaded 74807831229 Bytes, about 163 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 60 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230417043436_clickbench_pr_129902.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510807411
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510790057
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510917619
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510634027
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] LemonLiTree commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510649634
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18721:
URL: https://github.com/apache/doris/pull/18721#issuecomment-1510794467
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] LemonLiTree commented on a diff in pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "LemonLiTree (via GitHub)" <gi...@apache.org>.
LemonLiTree commented on code in PR #18721:
URL: https://github.com/apache/doris/pull/18721#discussion_r1168244015
##########
be/src/geo/wkb_parse.cpp:
##########
@@ -43,6 +87,36 @@ GeoParseStatus WkbParse::parse_wkb(std::istream& is, bool isEwkb, GeoShape** sha
return ctx.parse_status;
}
+WkbParseContext* WkbParse::read_hex(std::istream& is, WkbParseContext* ctx) {
+ // setup input/output stream
+ std::stringstream os(std::ios_base::binary | std::ios_base::in | std::ios_base::out);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 merged pull request #18721: [Improve](GEO)wkb input and output are represented as hexadecimal strings And delete EWKB
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #18721:
URL: https://github.com/apache/doris/pull/18721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org