You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jo...@apache.org on 2010/10/21 07:59:20 UTC

svn commit: r1025838 - /ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml

Author: jonesde
Date: Thu Oct 21 05:59:20 2010
New Revision: 1025838

URL: http://svn.apache.org/viewvc?rev=1025838&view=rev
Log:
Commented out condition added/fixed by Jacques in rev 1023842 that breaks various things because the updatePostalAddress/etc services call the updateContactMech method; this fixes that bug for now, and if this really should be a constraint the higher level services need to be changed to do something else, ie to not call the updateContactMech/etc services

Modified:
    ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml

Modified: ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml?rev=1025838&r1=1025837&r2=1025838&view=diff
==============================================================================
--- ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml (original)
+++ ofbiz/trunk/applications/party/script/org/ofbiz/party/contact/ContactMechServices.xml Thu Oct 21 05:59:20 2010
@@ -36,6 +36,9 @@ under the License.
     </simple-method>
 
     <simple-method method-name="updateContactMech" short-description="Update Contact Mechanism">
+        <!-- NOTE DEJ20101020: commenting these out becuase they make NO sense... the problem is that 
+            updatePostalAddress below in this file calls updateContactMech, so it must be allowed...
+            This was "fixed" by JLR in rev 1023842, so undoing part of that to get things working again.
         <if-compare field="parameters.contactMechTypeId" operator="equals" value="POSTAL_ADDRESS">
             <add-error><fail-property resource="PartyUiLabels" property="PartyServiceNotForPostalAddress"/></add-error>
         </if-compare>
@@ -43,6 +46,7 @@ under the License.
             <add-error><fail-property resource="PartyUiLabels" property="PartyServiceNotForTelecomNumber"/></add-error>
         </if-compare>
         <check-errors/>
+        -->
 
         <set field="successMessageProperty" value="PartyContactMechanismSuccessfullyUpdated"/>
         <if-compare field="parameters.contactMechTypeId" operator="equals" value="EMAIL_ADDRESS">