You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Steven Caswell <st...@yahoo.com> on 2002/03/08 00:50:45 UTC

[lang] test classes for commons.lang.exception package

Here are a set of test cases for the lang.exception classes.  If someone
could commit.


Steven Caswell
stevencaswell@yahoo.com
a.k.a Mungo Knotwise of Michel Delving
"One ring to rule them all, one ring to find them..."


Re: [lang] test classes for commons.lang.exception package

Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Steven Caswell" <st...@yahoo.com> writes:

> Ah. Yes.  Sorry for the oversight.  And thanks for the cleanup.

Thanks for the test cases Steve!

- Dan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [lang] test classes for commons.lang.exception package

Posted by Steven Caswell <st...@yahoo.com>.
Ah. Yes.  Sorry for the oversight.  And thanks for the cleanup.


Steven Caswell
stevencaswell@yahoo.com
a.k.a Mungo Knotwise of Michel Delving
"One ring to rule them all, one ring to find them..."


> -----Original Message-----
> From: dlr@despot.finemaltcoding.com 
> [mailto:dlr@despot.finemaltcoding.com] On Behalf Of Daniel Rall
> Sent: Saturday, March 09, 2002 12:46 PM
> To: Jakarta Commons Developers List
> Cc: stevencaswell@yahoo.com
> Subject: Re: [lang] test classes for commons.lang.exception package
> 
> 
> Daniel Rall <dl...@finemaltcoding.com> writes:
> 
> > "Steven Caswell" <st...@yahoo.com> writes:
> >
> >> Hi Dan.  I ran ant test.exception and everything works 
> fine. Is there 
> >> something else I can do to help resolve the problem?
> >
> > I changed the failure case to use assertEquals() instead of
> > assertTrue():
> >
> > test.exception:
> > Running exception package tests ...
> > ...F..
> > Time: 0.074
> > There was 1 failure:
> > 1) 
> > 
> testNestableDelegetePrintStackTrace(org.apache.commons.lang.ex
> ception.NestableDelegateTestCase)junit.framework.AssertionFail
> edError: stack trace substring(954,1022) == rethrown as 
> ThrowableNestedNestable partial stack trace place-holder 
> expected:<rethrown as ThrowableNestedNestable partial stack 
> trace place-holder> but was:< rethrown as 
> ThrowableNestedNestable partial stack trace place-holde>
> > 	at 
> > 
> org.apache.commons.lang.exception.NestableDelegateTestCase.testNestabl
> > eDelegetePrintStackTrace(NestableDelegateTestCase.java)
> 
> I figured it out.  Your test case was Windows-centric, always 
> assuming that line separators were of length 2.  I corrected 
> this by using the system property line.separator and getting 
> the length of that.
> 
> - Dan
> 



_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [lang] test classes for commons.lang.exception package

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Daniel Rall <dl...@finemaltcoding.com> writes:

> "Steven Caswell" <st...@yahoo.com> writes:
>
>> Hi Dan.  I ran ant test.exception and everything works fine. Is there
>> something else I can do to help resolve the problem?
>
> I changed the failure case to use assertEquals() instead of
> assertTrue():
>
> test.exception:
> Running exception package tests ...
> ...F..
> Time: 0.074
> There was 1 failure:
> 1) testNestableDelegetePrintStackTrace(org.apache.commons.lang.exception.NestableDelegateTestCase)junit.framework.AssertionFailedError: stack trace substring(954,1022) == rethrown as ThrowableNestedNestable partial stack trace place-holder expected:<rethrown as ThrowableNestedNestable partial stack trace place-holder> but was:<
> rethrown as ThrowableNestedNestable partial stack trace place-holde>
> 	at org.apache.commons.lang.exception.NestableDelegateTestCase.testNestableDelegetePrintStackTrace(NestableDelegateTestCase.java)

I figured it out.  Your test case was Windows-centric, always assuming
that line separators were of length 2.  I corrected this by using the
system property line.separator and getting the length of that.

- Dan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [lang] test classes for commons.lang.exception package

Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Steven Caswell" <st...@yahoo.com> writes:

> Hi Dan.  I ran ant test.exception and everything works fine. Is there
> something else I can do to help resolve the problem?

I changed the failure case to use assertEquals() instead of
assertTrue():

test.exception:
Running exception package tests ...
...F..
Time: 0.074
There was 1 failure:
1) testNestableDelegetePrintStackTrace(org.apache.commons.lang.exception.NestableDelegateTestCase)junit.framework.AssertionFailedError: stack trace substring(954,1022) == rethrown as ThrowableNestedNestable partial stack trace place-holder expected:<rethrown as ThrowableNestedNestable partial stack trace place-holder> but was:<
rethrown as ThrowableNestedNestable partial stack trace place-holde>
	at org.apache.commons.lang.exception.NestableDelegateTestCase.testNestableDelegetePrintStackTrace(NestableDelegateTestCase.java)

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [lang] test classes for commons.lang.exception package

Posted by Steven Caswell <st...@yahoo.com>.
Hi Dan.  I ran ant test.exception and everything works fine. Is there
something else I can do to help resolve the problem?


Steven Caswell
stevencaswell@yahoo.com
a.k.a Mungo Knotwise of Michel Delving
"One ring to rule them all, one ring to find them..."


> -----Original Message-----
> From: dlr@despot.finemaltcoding.com 
> [mailto:dlr@despot.finemaltcoding.com] On Behalf Of Daniel Rall
> Sent: Thursday, March 07, 2002 7:29 PM
> To: Jakarta Commons Developers List
> Cc: stevencaswell@yahoo.com
> Subject: Re: [lang] test classes for commons.lang.exception package
> 
> 
> Daniel Rall <dl...@finemaltcoding.com> writes:
> 
> > "Steven Caswell" <st...@yahoo.com> writes:
> >
> >> Here are a set of test cases for the lang.exception classes.  If 
> >> someone could commit.
> >
> > Thanks Steve, looking at them now.
> 
> I committed them, but a quick run didn't pass.  Could be my 
> local configuration, but I'd appreciate it if you'd try them 
> via `ant test.exception`.
> 
> Thanks, Dan
> 



_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [lang] test classes for commons.lang.exception package

Posted by Daniel Rall <dl...@finemaltcoding.com>.
Daniel Rall <dl...@finemaltcoding.com> writes:

> "Steven Caswell" <st...@yahoo.com> writes:
>
>> Here are a set of test cases for the lang.exception classes.  If someone
>> could commit.
>
> Thanks Steve, looking at them now.

I committed them, but a quick run didn't pass.  Could be my local
configuration, but I'd appreciate it if you'd try them via `ant
test.exception`.

Thanks, Dan

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: [lang] test classes for commons.lang.exception package

Posted by Daniel Rall <dl...@finemaltcoding.com>.
"Steven Caswell" <st...@yahoo.com> writes:

> Here are a set of test cases for the lang.exception classes.  If someone
> could commit.

Thanks Steve, looking at them now.

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>