You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Steven Rowe (JIRA)" <ji...@apache.org> on 2011/06/14 21:58:47 UTC

[jira] [Created] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
---------------------------------------------------------------------------------------------

                 Key: LUCENE-3204
                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
             Project: Lucene - Java
          Issue Type: Improvement
          Components: general/build
    Affects Versions: 3.3, 4.0
            Reporter: Steven Rowe
            Assignee: Steven Rowe
             Fix For: 3.3, 4.0
         Attachments: LUCENE-3204.patch

Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049372#comment-13049372 ] 

Steven Rowe commented on LUCENE-3204:
-------------------------------------

Committing shortly.

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-3204:
--------------------------------

    Attachment: LUCENE-3204.patch

Added CHANGES.txt entries, including mention of the fact that copies of the maven-ant-tasks jar in the Ant classpath take precedence over the copy in the Lucene/Solr source tree.

Committing shortly.

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch, LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049386#comment-13049386 ] 

Steven Rowe commented on LUCENE-3204:
-------------------------------------

I unpacked the jar, defaced the definitions file loaded by the <taskdef>: {{org/apache/maven/artifact/ant/antlib.xml}}, then repacked the now-mangled jar and put the result in {{~/.ant/lib/}}, while leaving intact the copy under {{lucene/lib/}}.

The result: the mangled copy under {{~/.ant/lib/}} is visited first, resulting in an error.  This means that the supplied version does *not* get preferred over what's already in {{~/.ant/lib/}}.

I don't think this is a serious problem, but I'll make mention of it in the CHANGES.txt entry (to be included in another iteration of the patch).

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049382#comment-13049382 ] 

Steven Rowe commented on LUCENE-3204:
-------------------------------------

bq. Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ?

I'm not sure.  How can I test this?  I removed the copy in {{lucene/lib/}} and put a copy of the jar in {{~/.ant/lib/}}.  {{ant generate-maven-artifacts}} still succeeds.

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe resolved LUCENE-3204.
---------------------------------

    Resolution: Fixed

Committed:

- trunk: r1135801, r1135818, r1135822, r1135825
- branch_3x: r1135827

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch, LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049374#comment-13049374 ] 

Uwe Schindler commented on LUCENE-3204:
---------------------------------------

I think that's fine. Does the supplied version of maven-ant-task automatically get preferred over whats already in ~/.ant/lib ?

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Steven Rowe updated LUCENE-3204:
--------------------------------

    Attachment: LUCENE-3204.patch

Patch implementing the idea.

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049448#comment-13049448 ] 

Uwe Schindler commented on LUCENE-3204:
---------------------------------------

Jenkins now complains because of missing license file: [https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console]

On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib.

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch, LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3204) Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts

Posted by "Steven Rowe (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13049451#comment-13049451 ] 

Steven Rowe commented on LUCENE-3204:
-------------------------------------

bq. Jenkins now complains because of missing license file: https://builds.apache.org/job/Lucene-Solr-tests-only-trunk/8840/console

It's the NOTICE file that's missing, and I've just added it.

bq. On Jenkins, I removed maven-ant-tasks from ~hudson/.ant/lib.

Thanks!

> Include maven-ant-tasks jar in the source tree and use this jar from generate-maven-artifacts
> ---------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3204
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3204
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: general/build
>    Affects Versions: 3.3, 4.0
>            Reporter: Steven Rowe
>            Assignee: Steven Rowe
>             Fix For: 3.3, 4.0
>
>         Attachments: LUCENE-3204.patch, LUCENE-3204.patch
>
>
> Currently, running {{ant generate-maven-artifacts}} requires the user to have {{maven-ant-tasks-*.jar}} in their Ant classpath, e.g. in {{~/.ant/lib/}}.  The build should instead rely on a copy of this jar included in the source tree.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org