You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/13 22:22:08 UTC

[GitHub] [kafka] jolshan commented on a diff in pull request #12972: KAFKA-14391; Add ConsumerGroupHeartbeat API

jolshan commented on code in PR #12972:
URL: https://github.com/apache/kafka/pull/12972#discussion_r1070126393


##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -185,11 +215,11 @@ public static ApiVersionsResponse createApiVersionsResponse(
     }
 
     public static ApiVersionCollection filterApis(
-        RecordVersion minRecordVersion,
-        ApiMessageType.ListenerType listenerType
+        Set<ApiKeys> enabledApi,

Review Comment:
   nit: Do we want to make this plural `enabledApis`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org