You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/23 12:58:46 UTC

[GitHub] [airflow] Khrol opened a new issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Khrol opened a new issue #11780:
URL: https://github.com/apache/airflow/issues/11780


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   These questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.12
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**:
   - **OS** (e.g. from /etc/os-release):
   - **Kernel** (e.g. `uname -a`):
   - **Install tools**:
   - **Others**:
   
   **What happened**:
   
   <!-- (please include exact error messages if you can) -->
   
   We have a DAG with ~1300 tasks. After the 1.10.11 -> 1.10.12 upgrade Dag file processing time increased from 3-6sec to 150-250sec.
   
   **What you expected to happen**:
   
   <!-- What do you think went wrong? -->
   
   It should be quick. 😄 
   We extended `AIRFLOW__CORE__DAG_FILE_PROCESSOR_TIMEOUT` to 600 instead of default 50.
   
   **How to reproduce it**:
   <!---
   
   
   
   As minimally and precisely as possible. Keep in mind we do not have access to your cluster or dags.
   
   If you are using kubernetes, please attempt to recreate the issue using minikube or kind.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md style of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   One task processing in our Dag takes ~0.3sec. The call to `get_failed_dep_statuses` method.
   If the new `NotPreviouslySkippedDep` is removed from dependencies, it's quick again (0.001s and less).
   
   **Anything else we need to know**:
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] yuqian90 edited a comment on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
yuqian90 edited a comment on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-715643092


   @kaxil  @Khrol the fix is in master but not in 1.10.*. I tried to cherry pick it in https://github.com/apache/airflow/pull/11010
   
   But the cherry-picked PR was closed. If we can merge it, this slowness will be fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-716732651


   Has been merged, will be part of 1.10.13 -- thanks @yuqian90 .
   
   Thanks @Khrol for reporting the issue


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-715608423


   cc @yuqian90 -- Any ideas, thoughts?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil closed issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
kaxil closed issue #11780:
URL: https://github.com/apache/airflow/issues/11780


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] Khrol commented on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
Khrol commented on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-716356186


   I agree that the fix is not a new feature but a bug fix and should be merged into 1.10.*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] yuqian90 commented on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
yuqian90 commented on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-715643092


   The fix is in master but not in 1.10.*. I tried to cherry pick it in https://github.com/apache/airflow/pull/11010
   
   Once it's merged in 1.10 this slowness will be addressed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] yuqian90 edited a comment on issue #11780: Performance degradation in 1.10.12 (https://github.com/apache/airflow/pull/7276/)

Posted by GitBox <gi...@apache.org>.
yuqian90 edited a comment on issue #11780:
URL: https://github.com/apache/airflow/issues/11780#issuecomment-715643092


   @kaxil  @Khrol the fix is in master but not in 1.10.*. I tried to cherry pick it in https://github.com/apache/airflow/pull/11010
   
   But the cherry-picked PR was closed. Of we can merge it, this slowness will be fixed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org