You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/25 18:00:56 UTC

[GitHub] [spark] tgravescs commented on a change in pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window

tgravescs commented on a change in pull request #27943: [SPARK-31179] Fast fail the connection while last connection failed in fast fail time window
URL: https://github.com/apache/spark/pull/27943#discussion_r398060555
 
 

 ##########
 File path: common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java
 ##########
 @@ -86,6 +87,7 @@
   private EventLoopGroup workerGroup;
   private final PooledByteBufAllocator pooledAllocator;
   private final NettyMemoryMetrics metrics;
+  private final double fastFailTimeWindow;
 
 Review comment:
   we don't really need this as double, just case to an int. ioRetryWaitTimeMs returns int

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org