You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/11/12 05:38:00 UTC
[jira] [Updated] (HADOOP-18006) maven-enforcer-plugin's execution
of banned-illegal-imports gets overridden in child poms
[ https://issues.apache.org/jira/browse/HADOOP-18006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated HADOOP-18006:
------------------------------------
Labels: pull-request-available (was: )
> maven-enforcer-plugin's execution of banned-illegal-imports gets overridden in child poms
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-18006
> URL: https://issues.apache.org/jira/browse/HADOOP-18006
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When we specify any maven plugin with execution tag in the parent as well as child modules, child module plugin overrides parent plugin. For instance, when {{banned-illegal-imports}} is applied for any child module with only one banned import (let’s say {{{}Preconditions{}}}), then only that banned import is covered by that child module and all imports defined in parent module (e.g Sets, Lists etc) are overridden and they are no longer applied.
> After this [commit|https://github.com/apache/hadoop/commit/62c86eaa0e539a4307ca794e0fcd502a77ebceb8], hadoop-hdfs module will not complain about {{Sets}} even if i import it from guava banned imports but on the other hand, hadoop-yarn module doesn’t have any child level {{banned-illegal-imports}} defined so yarn modules will fail if {{Sets}} guava import is used.
> So going forward, it would be good to replace guava imports with Hadoop’s own imports module-by-module and only at the end, we should add new entry to parent pom {{banned-illegal-imports}} list.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org