[GitHub] [flink] wuchong commented on a change in pull request #11493: [FLINK-16160][table-common] Support computed column, proctime and watermark in Schema descriptor

[GitBox <gi...@apache.org>]

wuchong commented on a change in pull request #11493: [FLINK-16160][table-common] Support computed column, proctime and watermark in Schema descriptor
URL: https://github.com/apache/flink/pull/11493#discussion_r399098167
 
 

 ##########
 File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/descriptors/Rowtime.java
 ##########
 @@ -22,12 +22,17 @@
 import org.apache.flink.api.common.typeinfo.Types;
 import org.apache.flink.table.sources.tsextractors.TimestampExtractor;
 import org.apache.flink.table.sources.wmstrategies.WatermarkStrategy;
+import org.apache.flink.table.types.DataType;
 
 import java.util.Map;
 
 /**
  * Rowtime descriptor for describing an event time attribute in the schema.
+ *
+ * @deprecated This class will be removed in future versions as is inconsistent with watermarks of
 
 Review comment:
   as it is inconsistent with DDL watermark syntax. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services