[GitHub] [kafka] bbejeck commented on a diff in pull request #13565: KAFKA-14834: [N/9] Disable versioned-stores for unsupported operations

["bbejeck (via GitHub)" <gi...@apache.org>]

bbejeck commented on code in PR #13565:
URL: https://github.com/apache/kafka/pull/13565#discussion_r1166100148


##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableImpl.java:
##########
@@ -539,6 +540,10 @@ public <K1> KStream<K1, V> toStream(final KeyValueMapper<? super K, ? super V, ?
 
     @Override
     public KTable<K, V> suppress(final Suppressed<? super K> suppressed) {
+        if (graphNode.isOutputVersioned().isPresent() && graphNode.isOutputVersioned().get()) {

Review Comment:
   I agree - IMHO it's better to check and throw from the source of the problem



##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilderTest.java:
##########
@@ -177,6 +178,24 @@ public void shouldBuildSimpleGlobalTableTopology() {
         assertEquals("globalTable", stateStores.get(0).name());
     }
 
+    @Test
+    public void shouldThrowOnVersionedStoreSupplierForGlobalTable() {
+        final MaterializedInternal<String, String, KeyValueStore<Bytes, byte[]>> materializedInternal =

Review Comment:
   Why must we use `MaterializedInternal` vs. `Materialized` here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org