You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/09 21:21:10 UTC

[GitHub] [spark] zero323 edited a comment on pull request #29991: [WIP][INFRA] Change default R arch from i386 to x64 and parametrize BINPREF

zero323 edited a comment on pull request #29991:
URL: https://github.com/apache/spark/pull/29991#issuecomment-706407462


   __Notes__:
   
   I am not sure if we should put MinGW here. Ultimately we want to use one provided by Rtools, right? 
   
   https://github.com/apache/spark/blob/2e07ed30418d45e89d108bc4bc020d2933c20a3a/dev/appveyor-install-dependencies.ps1#L45
   
   Here 
   
   https://github.com/apache/spark/blob/2e07ed30418d45e89d108bc4bc020d2933c20a3a/dev/appveyor-install-dependencies.ps1#L70
   
   `$RtoolsDrive + '\Rtools40\' + $gccPath + '\bin;'` doesn't seem to point to existing directory and it seem like it shouldn't be added in the first place. Shall we remove it?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org