You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Eric Covener <co...@gmail.com> on 2015/10/23 21:22:27 UTC

Fwd: [Bug 57785] REDIRECT_URL is not suitable for use in server-generated pages

My opinion is to make it opt-in before the next 2.4, but I am not
committed to that.

Before I do doc, any other thoughts?

http://people.apache.org/~covener/patches/redirecturl-optin.diff

This adds a directive to core.c called QualifyRedirectURL that  must
be set to ON to run the 2.4.17 code.

---------- Forwarded message ----------
From:  <bu...@apache.org>
Date: Fri, Oct 23, 2015 at 12:55 PM
Subject: [Bug 57785] REDIRECT_URL is not suitable for use in
server-generated pages
To: bugs@httpd.apache.org


https://bz.apache.org/bugzilla/show_bug.cgi?id=57785

--- Comment #7 from Jacob P <ja...@cpanel.net> ---
Here at cPanel we are reverting our 2.4.17 release and are going to re-release
2.4.16. Too many issues with mod_rewrite/REDIRECT_URL causing a *lot* of
applications to stop working.

--
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org



-- 
Eric Covener
covener@gmail.com

Re: [Bug 57785] REDIRECT_URL is not suitable for use in server-generated pages

Posted by Nick Kew <ni...@webthing.com>.
On Fri, 23 Oct 2015 15:22:27 -0400
Eric Covener <co...@gmail.com> wrote:

> My opinion is to make it opt-in before the next 2.4, but I am not
> committed to that.

Hehe.  I was leaning towards introducing separate vars for
full URL and fragment.  But your patch looks good to me.

-- 
Nick Kew

Re: [Bug 57785] REDIRECT_URL is not suitable for use in server-generated pages

Posted by Jacob Perkins <ja...@cpanel.net>.
+1 on this as well. That looks like a good fix that won’t break existing functionality. I know a lot of apps are working on updates now to fix these changes, but it’ll still be good to have this pushed back a bit.

Thank you!
—
Jacob Perkins
Product Owner
cPanel Inc.

jacob.perkins@cpanel.net <ma...@cpanel.net>
Office:  713-529-0800 x 4046
Cell:  713-560-8655

> On Oct 23, 2015, at 2:39 PM, Yann Ylavic <yl...@gmail.com> wrote:
> 
> On Fri, Oct 23, 2015 at 9:22 PM, Eric Covener <co...@gmail.com> wrote:
>> My opinion is to make it opt-in before the next 2.4, but I am not
>> committed to that.
>> 
>> Before I do doc, any other thoughts?
>> 
>> http://people.apache.org/~covener/patches/redirecturl-optin.diff
> 
> Looks sensible, +1


Re: [Bug 57785] REDIRECT_URL is not suitable for use in server-generated pages

Posted by Yann Ylavic <yl...@gmail.com>.
On Fri, Oct 23, 2015 at 9:22 PM, Eric Covener <co...@gmail.com> wrote:
> My opinion is to make it opt-in before the next 2.4, but I am not
> committed to that.
>
> Before I do doc, any other thoughts?
>
> http://people.apache.org/~covener/patches/redirecturl-optin.diff

Looks sensible, +1

Re: [Bug 57785] REDIRECT_URL is not suitable for use in server-generated pages

Posted by Jim Jagielski <ji...@jaguNET.com>.
+1...

I think I'd like to do a 2.4.18 release mid-Nov and pick up
these pieces as well as some http/2 fixes.

> On Oct 23, 2015, at 3:22 PM, Eric Covener <co...@gmail.com> wrote:
> 
> My opinion is to make it opt-in before the next 2.4, but I am not
> committed to that.
> 
> Before I do doc, any other thoughts?
> 
> http://people.apache.org/~covener/patches/redirecturl-optin.diff
> 
> This adds a directive to core.c called QualifyRedirectURL that  must
> be set to ON to run the 2.4.17 code.
> 
> ---------- Forwarded message ----------
> From:  <bu...@apache.org>
> Date: Fri, Oct 23, 2015 at 12:55 PM
> Subject: [Bug 57785] REDIRECT_URL is not suitable for use in
> server-generated pages
> To: bugs@httpd.apache.org
> 
> 
> https://bz.apache.org/bugzilla/show_bug.cgi?id=57785
> 
> --- Comment #7 from Jacob P <ja...@cpanel.net> ---
> Here at cPanel we are reverting our 2.4.17 release and are going to re-release
> 2.4.16. Too many issues with mod_rewrite/REDIRECT_URL causing a *lot* of
> applications to stop working.
> 
> --
> You are receiving this mail because:
> You are the assignee for the bug.
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
> For additional commands, e-mail: bugs-help@httpd.apache.org
> 
> 
> 
> -- 
> Eric Covener
> covener@gmail.com