[GitHub] [maven-scm] pzygielo commented on pull request #107: [SCM-946] Added @threadSafe for parallel execution

[GitBox <gi...@apache.org>]

pzygielo commented on pull request #107:
URL: https://github.com/apache/maven-scm/pull/107#issuecomment-971879439


   I don't understand how this shall help, as `plugin.xml` _already_ has following:
   ```xml
       <mojo>
         <goal>tag</goal>
   ...
         <threadSafe>false</threadSafe>
         <parameters>
   ...
   ```
   As there is no reproducer I used mine, which might be wrong, and this change for `scm:tag` still gives me
   ```
   [WARNING] *****************************************************************
   [WARNING] * Your build is requesting parallel execution, but project      *
   [WARNING] * contains the following plugin(s) that have goals not marked   *
   [WARNING] * as @threadSafe to support parallel building.                  *
   [WARNING] * While this /may/ work fine, please look for plugin updates    *
   [WARNING] * and/or request plugins be made thread-safe.                   *
   [WARNING] * If reporting an issue, report it against the plugin in        *
   [WARNING] * question, not against maven-core                              *
   [WARNING] *****************************************************************
   [WARNING] The following plugins are not marked @threadSafe in Xavier:
   [WARNING] org.apache.maven.plugins:maven-scm-plugin:1.11.3-SNAPSHOT
   [WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
   [WARNING] *****************************************************************
   ```
   thus I can't confirm https://github.com/apache/maven-scm/pull/107#issuecomment-971673991.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org