[jira] Commented: (THRIFT-181) C# SSL Support

["Michael Greene (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658962#action_12658962 ] 

Michael Greene commented on THRIFT-181:
---------------------------------------

I haven't had a chance to use these classes, but speaking to the code:

 * The TODOs shouldn't enter the codebase.  If they still need to be done, they should be taken care of before these patches are accepted.

* -1 for author information

* -1 for dependency on log4net.  One way you can get around this is by allowing a logger delegate a la THRIFT-25.

* The spacing should be done in tabs to match the existing library.

I do think SSL is something sorely lacking in the C# implementation and would like to see this further developed.  This is a great start.


> C# SSL Support
> --------------
>
>                 Key: THRIFT-181
>                 URL: https://issues.apache.org/jira/browse/THRIFT-181
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Library (C#)
>         Environment: VS 2008
>            Reporter: Anthony Abate
>         Attachments: TSSLServerSocket.cs, TSSLSocket.cs
>
>
> I Created  TSecureSocket and TSecureSocketServer classes which wrap tcpclient with ssl.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.