[GitHub] [phoenix-connectors] twdsilva commented on a change in pull request #2: PHOENIX-5197: Use extraOptions to set the configuration for Spark Workers

[GitBox <gi...@apache.org>]

twdsilva commented on a change in pull request #2: PHOENIX-5197: Use extraOptions to set the configuration for Spark Workers
URL: https://github.com/apache/phoenix-connectors/pull/2#discussion_r273186988
 
 

 ##########
 File path: phoenix-spark/src/main/java/org/apache/phoenix/spark/datasource/v2/writer/PhoenixDataWriter.java
 ##########
 @@ -51,7 +53,7 @@ public PhoenixDataWriter(PhoenixDataSourceWriteOptions options) {
         String scn = options.getScn();
         String tenantId = options.getTenantId();
         String zkUrl = options.getZkUrl();
-        Properties overridingProps = new Properties();
+        Properties overridingProps = options.getOverriddenProps();
 
 Review comment:
   Can options.getOverriddenProps return null?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services