You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@edgent.apache.org by Cazen <gi...@git.apache.org> on 2016/04/06 04:55:47 UTC

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

GitHub user Cazen opened a pull request:

    https://github.com/apache/incubator-quarks/pull/77

    [QUARKS-121] Fix JavaDoc error except </P> tag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks fixJavaDocErr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 75f9699ff7e33dbad1eb924cf14e3cad09550a00
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T02:29:12Z

    Fix JavaDoc Error in whole repo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-quarks/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:

    https://github.com/apache/incubator-quarks/pull/77

    [QUARKS-121] Fix JavaDoc error except </P> tag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks fixJavaDocErr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 75f9699ff7e33dbad1eb924cf14e3cad09550a00
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T02:29:12Z

    Fix JavaDoc Error in whole repo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:

    https://github.com/apache/incubator-quarks/pull/77

    [QUARKS-121] Fix JavaDoc error except </P> tag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks fixJavaDocErr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 75f9699ff7e33dbad1eb924cf14e3cad09550a00
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T02:29:12Z

    Fix JavaDoc Error in whole repo

commit 28da8af56602a98d9e9a4709519d48d17b4c0434
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T23:56:04Z

    Rollback escape character and change <code> tag to {@code}

commit 8ce4a2509c5c1487e7419f3ed3ace0b86aa0f701
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-15T06:25:36Z

    Merge remote-tracking branch 'upstream/master' into fixJavaDocErr

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] [WIP] Fix JavaDoc erro...

Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:

    https://github.com/apache/incubator-quarks/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] [WIP] Fix JavaDoc erro...

Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:

    https://github.com/apache/incubator-quarks/pull/77

    [QUARKS-121] [WIP] Fix JavaDoc error except </P> tag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks fixJavaDocErr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 75f9699ff7e33dbad1eb924cf14e3cad09550a00
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T02:29:12Z

    Fix JavaDoc Error in whole repo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:

    https://github.com/apache/incubator-quarks/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] [WIP] Fix JavaDoc erro...

Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:

    https://github.com/apache/incubator-quarks/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] [WIP] Fix JavaDoc erro...

Posted by Cazen <gi...@git.apache.org>.
GitHub user Cazen reopened a pull request:

    https://github.com/apache/incubator-quarks/pull/77

    [QUARKS-121] [WIP] Fix JavaDoc error except </P> tag

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Cazen/incubator-quarks fixJavaDocErr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-quarks/pull/77.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #77
    
----
commit 75f9699ff7e33dbad1eb924cf14e3cad09550a00
Author: cazen.lee <ca...@samsung.com>
Date:   2016-04-06T02:29:12Z

    Fix JavaDoc Error in whole repo

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] Fix JavaDoc error exce...

Posted by Cazen <gi...@git.apache.org>.
Github user Cazen closed the pull request at:

    https://github.com/apache/incubator-quarks/pull/77


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-quarks pull request: [QUARKS-121] [WIP] Fix JavaDoc erro...

Posted by dlaboss <gi...@git.apache.org>.
Github user dlaboss commented on a diff in the pull request:

    https://github.com/apache/incubator-quarks/pull/77#discussion_r58713114
  
    --- Diff: analytics/sensors/src/main/java/quarks/analytics/sensors/Filters.java ---
    @@ -99,7 +99,7 @@ private Filters() {}
          * <LI>The first tuple.</LI>
          * </UL>
          * <BR>
    -     * <img src="doc-files/deadband.png" alt="Deadband example"/>
    +     * <img src="doc-files/deadband.png" alt="Deadband example">
    --- End diff --
    
    I think the original above is what's needed.  Was the image rendering wrong for you?
    
    Thanks for many of the other fixes.
    
    For what it's worth, it seems only the "<" needs to be escaped to avoid confusing browsers.  ">" is OK.  So for example, the changes to Connector below seem unnecessary.  Were you seeing a rendering problem?
    
    Also &lt;pre> and/or &lt;code> provide some "protection" as well - e.g., line 157 in TStream below already renders correctly.
    
    FWIW, I've taken to trying to use the following idiom as it seems "stuff" can then basically anything, particularly unescaped "<", so I can just write / copy code in its natural form
    &lt;pre>{@code
    stuff...
    }&lt;/pre>


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---