You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/10/27 10:00:30 UTC
[PR] Build: `GitInfo` function to build a raw github content URL [polaris]
snazy opened a new pull request, #2910:
URL: https://github.com/apache/polaris/pull/2910
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2910:
URL: https://github.com/apache/polaris/pull/2910#discussion_r2483891294
##########
build-logic/src/main/kotlin/GitInfo.kt:
##########
@@ -56,7 +60,8 @@ class GitInfo(val gitHead: String, val gitDescribe: String) {
execGit(rootProject, "describe", "--always", "--dirty")
}
else ""
- val gitInfo = GitInfo(gitHead, gitDescribe)
+ val rawLinkRef = if (isRelease) gitDescribe else "HEAD"
Review Comment:
Yea - the link would be wrong and put in some relevant fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2910:
URL: https://github.com/apache/polaris/pull/2910#discussion_r2477132549
##########
build-logic/src/main/kotlin/GitInfo.kt:
##########
@@ -56,7 +60,8 @@ class GitInfo(val gitHead: String, val gitDescribe: String) {
execGit(rootProject, "describe", "--always", "--dirty")
}
else ""
- val gitInfo = GitInfo(gitHead, gitDescribe)
+ val rawLinkRef = if (isRelease) gitDescribe else "HEAD"
Review Comment:
it says 'abcdef-dirty' (not resolvable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #2910:
URL: https://github.com/apache/polaris/pull/2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #2910:
URL: https://github.com/apache/polaris/pull/2910#discussion_r2477132549
##########
build-logic/src/main/kotlin/GitInfo.kt:
##########
@@ -56,7 +60,8 @@ class GitInfo(val gitHead: String, val gitDescribe: String) {
execGit(rootProject, "describe", "--always", "--dirty")
}
else ""
- val gitInfo = GitInfo(gitHead, gitDescribe)
+ val rawLinkRef = if (isRelease) gitDescribe else "HEAD"
Review Comment:
it potentially says 'abcdef-dirty' (not resolvable) - and the commit may not be in the apache/polaris repo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2910:
URL: https://github.com/apache/polaris/pull/2910#discussion_r2474274706
##########
build-logic/src/main/kotlin/GitInfo.kt:
##########
@@ -56,7 +60,8 @@ class GitInfo(val gitHead: String, val gitDescribe: String) {
execGit(rootProject, "describe", "--always", "--dirty")
}
else ""
- val gitInfo = GitInfo(gitHead, gitDescribe)
+ val rawLinkRef = if (isRelease) gitDescribe else "HEAD"
Review Comment:
nit: why not use `gitDescribe` for non-releases? `HEAD` in GH may be off with respect to the current state of the code during build 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #2910:
URL: https://github.com/apache/polaris/pull/2910#discussion_r2478971635
##########
build-logic/src/main/kotlin/GitInfo.kt:
##########
@@ -56,7 +60,8 @@ class GitInfo(val gitHead: String, val gitDescribe: String) {
execGit(rootProject, "describe", "--always", "--dirty")
}
else ""
- val gitInfo = GitInfo(gitHead, gitDescribe)
+ val rawLinkRef = if (isRelease) gitDescribe else "HEAD"
Review Comment:
Does it matter that the commit is not in GH for not released code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Build: `GitInfo` function to build a raw github content URL [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on PR #2910:
URL: https://github.com/apache/polaris/pull/2910#issuecomment-3450439872
Depends on #2908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org