You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Veit Guna (JIRA)" <ji...@apache.org> on 2006/05/31 22:17:16 UTC

[jira] Created: (SHALE-182) s:token tag doesn't allow sending a form, when any validation error occurs on page

s:token tag doesn't allow sending a form, when any validation error occurs on page
----------------------------------------------------------------------------------

         Key: SHALE-182
         URL: http://issues.apache.org/struts/browse/SHALE-182
     Project: Shale
        Type: Bug

  Components: Core  
    Versions: Nightly    
 Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)
    Reporter: Veit Guna


When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
the form has already been submitted and stays on the page.

I consider this as a bug...


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Commented: (SHALE-182) s:token tag doesn't allow sending a form, when any validation error occurs on page

Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
    [ http://issues.apache.org/struts/browse/SHALE-182?page=comments#action_37428 ] 

Craig McClanahan commented on SHALE-182:
----------------------------------------

Yep, that's a bug all right.  It is a regression introduced as part of fixing a different bug where the token would only protect you from one "duplicate submit" attempt, but not more than one.  I'll look into it ASAP.


> s:token tag doesn't allow sending a form, when any validation error occurs on page
> ----------------------------------------------------------------------------------
>
>          Key: SHALE-182
>          URL: http://issues.apache.org/struts/browse/SHALE-182
>      Project: Shale
>         Type: Bug

>   Components: Core
>     Versions: Nightly
>  Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)
>     Reporter: Veit Guna

>
> When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
> the form has already been submitted and stays on the page.
> I consider this as a bug...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (SHALE-182) s:token tag doesn't allow sending a form, when any validation error occurs on page

Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SHALE-182?page=all ]

Craig McClanahan reassigned SHALE-182:
--------------------------------------

    Assign To: Craig McClanahan

> s:token tag doesn't allow sending a form, when any validation error occurs on page
> ----------------------------------------------------------------------------------
>
>          Key: SHALE-182
>          URL: http://issues.apache.org/struts/browse/SHALE-182
>      Project: Shale
>         Type: Bug

>   Components: Core
>     Versions: Nightly
>  Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)
>     Reporter: Veit Guna
>     Assignee: Craig McClanahan

>
> When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
> the form has already been submitted and stays on the page.
> I consider this as a bug...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Closed: (SHALE-182) s:token tag doesn't allow sending a form, when any validation error occurs on page

Posted by "Veit Guna (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SHALE-182?page=all ]
     
Veit Guna closed SHALE-182:
---------------------------


works like a charm now. thanks.


> s:token tag doesn't allow sending a form, when any validation error occurs on page
> ----------------------------------------------------------------------------------
>
>          Key: SHALE-182
>          URL: http://issues.apache.org/struts/browse/SHALE-182
>      Project: Shale
>         Type: Bug

>   Components: Core
>     Versions: Nightly
>  Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)
>     Reporter: Veit Guna
>     Assignee: Craig McClanahan
>      Fix For: 1.0.3

>
> When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
> the form has already been submitted and stays on the page.
> I consider this as a bug...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (SHALE-182) s:token tag doesn't allow sending a form, when any validation error occurs on page

Posted by "Craig McClanahan (JIRA)" <ji...@apache.org>.
     [ http://issues.apache.org/struts/browse/SHALE-182?page=all ]
     
Craig McClanahan resolved SHALE-182:
------------------------------------

    Fix Version: 1.0.3
     Resolution: Fixed

Fix this bug by checking for the existence of any queued FacesMessages.  If there are any such messages (such as from a validation failure on a different input component in the same form), bypass the validation of the token itself (which has the side effect of not allowing this validation to occur on the later submit with the corrected form information).  This fix is available in nightly build 20060627, and will be fixed in the upcoming 1.0.3 release.


> s:token tag doesn't allow sending a form, when any validation error occurs on page
> ----------------------------------------------------------------------------------
>
>          Key: SHALE-182
>          URL: http://issues.apache.org/struts/browse/SHALE-182
>      Project: Shale
>         Type: Bug

>   Components: Core
>     Versions: Nightly
>  Environment: Windows XP, Tomcat 5.5, Myfaces 1.1.1 + Facelets 1.1.2, shale core 1.0.3-SNAPSHOT (shale-framework-20060530.zip)
>     Reporter: Veit Guna
>     Assignee: Craig McClanahan
>      Fix For: 1.0.3

>
> When using the token tag to avoid double submits, it doesn't allow the form to be submitted if any validation error occurs (e.g. required). It then says, that
> the form has already been submitted and stays on the page.
> I consider this as a bug...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira