You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/08/31 12:43:29 UTC
[GitHub] [incubator-pekko] He-Pin opened a new issue, #601: Deprecate `statefulMapConcat`
He-Pin opened a new issue, #601:
URL: https://github.com/apache/incubator-pekko/issues/601
Motivation:
As the `statefulMapConcat` not handing the `upstreamFinished` event, so when the stream is complete, the ongoing state keeded in the closure can be lost.
I suggest we annotate that in the scaladoc and deprecate the usage, and infavor the `statefulMap`
As the tests in https://github.com/Kotlin/kotlinx.coroutines/pull/3868 shows and the origin Akka issue for statefulMap:https://github.com/akka/akka/issues/31077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on issue #601: Deprecate `statefulMapConcat`
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on issue #601:
URL: https://github.com/apache/incubator-pekko/issues/601#issuecomment-1701705004
Can we deprecate things in the 1.0.x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #601: Deprecate `statefulMapConcat`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #601:
URL: https://github.com/apache/incubator-pekko/issues/601#issuecomment-1701708964
> Can we deprecate things in the 1.0.x ?
yes, we can deprecate code in 1.0.x
something like
`@deprecated("This function has been replace by <otherFunctionName>", "1.0.2")` (the 2nd string is the version number)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on issue #601: Deprecate `statefulMapConcat`
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on issue #601:
URL: https://github.com/apache/incubator-pekko/issues/601#issuecomment-1700975150
Is this something that can be done in Pekko 1.0.2? We should at least consider updating the Pekko 1.0 docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin closed issue #601: Deprecate `statefulMapConcat`
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed issue #601: Deprecate `statefulMapConcat`
URL: https://github.com/apache/incubator-pekko/issues/601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org