[GitHub] [streampipes] tenthe commented on a diff in pull request #1093: Sp 1085

[GitBox <gi...@apache.org>]

tenthe commented on code in PR #1093:
URL: https://github.com/apache/streampipes/pull/1093#discussion_r1071456267


##########
streampipes-extensions-management/src/main/java/org/apache/streampipes/extensions/management/connect/adapter/model/pipeline/AdapterEventPreviewPipeline.java:
##########
@@ -79,4 +80,9 @@ public Map<String, GuessTypeInfo> makePreview() {
         .collect(Collectors.toMap(Map.Entry::getKey,
             e -> new GuessTypeInfo(e.getValue().getClass().getCanonicalName(), e.getValue())));
   }
+
+  @Override
+  public EventSchema getResultingEventSchema() {
+    return null;

Review Comment:
   This is only temporary. In the future we probably will replace the class `AdapterEventPreviewPipeline` with a regular `AdapterPipeline` that uses a different sink.
   I had to add it here to remove the dependency of the `FileStreamProtocol` with the internal adapter implementation.
   If you have an idea on how to remove it, I'm happy to discuss it. If there is no quick solution, I would suggest to leave it as it is and remove it during the revision of the connect API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org