You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2018/02/07 18:51:46 UTC
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 6:51 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed James' comment.
Summary (updated)
-----------------
Added provider assignments into `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
A new `assignments` field is added to the `DiskProfileMapping` protobuf
so that the URI disk profile adaptor can be customized to notify each
resource provider a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/4/
Changes: https://reviews.apache.org/r/65538/diff/3-4/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197016
-----------------------------------------------------------
FAIL: Failed to apply the dependent review: 65520.
Failed command: `python.exe .\support\apply-reviews.py -n -r 65520`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
Relevant logs:
- [apply-review-65520-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538/logs/apply-review-65520-stdout.log):
```
error: patch failed: src/tests/storage_local_resource_provider_tests.cpp:73
error: src/tests/storage_local_resource_provider_tests.cpp: patch does not apply
```
- Mesos Reviewbot Windows
On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 6:51 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added provider assignments into
`disk_profile.proto`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197009
-----------------------------------------------------------
Fix it, then Ship it!
Can you update the summary and description of this review accordingly?
src/resource_provider/storage/disk_profile.proto
Line 32 (original), 51 (patched)
<https://reviews.apache.org/r/65538/#comment277120>
I don't change the tag number.
- Jie Yu
On Feb. 7, 2018, 6:51 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 6:51 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A new `assignments` field is added to the `DiskProfileMapping` protobuf
> so that the URI disk profile adaptor can be customized to notify each
> resource provider a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197048
-----------------------------------------------------------
PASS: Mesos patch 65538 was successfully built and tested.
Reviews applied: `['65553', '65554', '65538']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/65538
- Mesos Reviewbot Windows
On Feb. 7, 2018, 1:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 1:07 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by James DeFelice <ja...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197063
-----------------------------------------------------------
Ship it!
Ship It!
- James DeFelice
On Feb. 7, 2018, 9:07 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2018, 9:07 p.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added resource provider selectors in
`disk_profile.proto`.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/#review197113
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 8, 2018, 4:36 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65538/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 4:36 a.m.)
>
>
> Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
>
>
> Bugs: MESOS-8510
> https://issues.apache.org/jira/browse/MESOS-8510
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds two selectors to the `CSIManifest` protobuf so that the
> URI disk profile adaptor can be customized to notify each resource
> provider with a different set of profiles.
>
>
> Diffs
> -----
>
> src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
>
>
> Diff: https://reviews.apache.org/r/65538/diff/6/
>
>
> Testing
> -------
>
> Tests done later in chain.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 65538: Added resource provider selectors in
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 4:36 a.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Summary (updated)
-----------------
Added resource provider selectors in `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description
-------
This patch adds two selectors to the `CSIManifest` protobuf so that the
URI disk profile adaptor can be customized to notify each resource
provider with a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/6/
Changes: https://reviews.apache.org/r/65538/diff/5-6/
Testing
-------
Tests done later in chain.
Thanks,
Chun-Hung Hsiao
Re: Review Request 65538: WIP: Added profile selectors in
`disk_profile.proto`.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65538/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 9:07 p.m.)
Review request for mesos, James DeFelice, Jie Yu, and Joseph Wu.
Changes
-------
Addressed Jie's comments.
Summary (updated)
-----------------
WIP: Added profile selectors in `disk_profile.proto`.
Bugs: MESOS-8510
https://issues.apache.org/jira/browse/MESOS-8510
Repository: mesos
Description (updated)
-------
This patch adds two selectors to the `CSIManifest` protobuf so that the
URI disk profile adaptor can be customized to notify each resource
provider with a different set of profiles.
Diffs (updated)
-----
src/resource_provider/storage/disk_profile.proto 6cf1f8abcd24e45a292efc95a395f90bb2140da2
Diff: https://reviews.apache.org/r/65538/diff/5/
Changes: https://reviews.apache.org/r/65538/diff/4-5/
Testing
-------
Thanks,
Chun-Hung Hsiao