You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2021/04/18 17:37:10 UTC
[Impala-ASF-CR] WIP: upgrading some python requirements.
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17323
Change subject: WIP: upgrading some python requirements.
......................................................................
WIP: upgrading some python requirements.
Just checking to see if removing adls python packages breaks any tests
Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
---
M infra/python/deps/adls-requirements.txt
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/1
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] WIP: upgrading some python requirements.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: WIP: upgrading some python requirements.
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Apr 2021 23:28:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Upgrading Python cryptography library
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python cryptography library
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt
File infra/python/deps/adls-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24
PS2, Line 24: cryptography==3.2
> I don't actually have an ADLS environment set up. Do you?
I don't have one at hand, but I will look into how to run the tests with ADLS. Is it ok if I'll run the tests some time this week and will report back?
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 May 2021 14:39:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] WIP: upgrading some python requirements.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: WIP: upgrading some python requirements.
......................................................................
Patch Set 1:
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/
Appears just to be a flaky test. Here's an exhaustive run that passed:
https://jenkins.impala.io/view/Utility/job/ubuntu-16.04-from-scratch/13700/
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Comment-Date: Mon, 19 Apr 2021 13:38:59 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Upgrading Python cryptography library
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python cryptography library
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt
File infra/python/deps/adls-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24
PS2, Line 24: cryptography==3.2
> I don't have one at hand, but I will look into how to run the tests with AD
Any updates on this?
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 22 May 2021 16:35:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python cryptography library
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python cryptography library
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt
File infra/python/deps/adls-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24
PS2, Line 24: cryptography==3.2
> I don't have one at hand, but I will look into how to run the tests with AD
SGTM! :-)
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 May 2021 19:35:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python crptography library
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python crptography library
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8690/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 May 2021 17:55:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Upgrading Python cryptography library
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17323
to look at the new patch set (#3).
Change subject: Upgrading Python cryptography library
......................................................................
Upgrading Python cryptography library
For release notes, see https://cryptography.io/en/latest/changelog/
Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
---
M infra/python/deps/adls-requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/3
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] WIP: upgrading some python requirements.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: WIP: upgrading some python requirements.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8593/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Apr 2021 17:56:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] WIP: upgrading some python requirements.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: WIP: upgrading some python requirements.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7079/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 18 Apr 2021 17:40:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Upgrading Python cryptography library
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python cryptography library
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG@7
PS2, Line 7: crptography
> typo, missing first y
Done
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt
File infra/python/deps/adls-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24
PS2, Line 24: cryptography==3.2
> about testing: this change only affects ADLS environments, which is not cov
I don't actually have an ADLS environment set up. Do you?
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 May 2021 13:37:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python crptography library
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python crptography library
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG@7
PS2, Line 7: crptography
typo, missing first y
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt
File infra/python/deps/adls-requirements.txt:
http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24
PS2, Line 24: cryptography==3.2
about testing: this change only affects ADLS environments, which is not covered in GVO. It would be great to run the tests in ADLS environment to ensure that nothing breaks. (there are several breaking changes in the change list)
Note that these libraries are only used in the test environment, not in Impala itself, so the change cannot break a development environment,
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Mon, 10 May 2021 15:01:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Upgrading Python crptography library
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17323
to look at the new patch set (#2).
Change subject: Upgrading Python crptography library
......................................................................
Upgrading Python crptography library
For release notes, see https://cryptography.io/en/latest/changelog/
Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
---
M infra/python/deps/adls-requirements.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/23/17323/2
--
To view, visit http://gerrit.cloudera.org:8080/17323
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05
Gerrit-Change-Number: 17323
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>