You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Knupp (Code Review)" <ge...@cloudera.org> on 2019/11/22 18:58:21 UTC
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
David Knupp has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14788
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
---
M lib/python/impala_py_lib/helpers.py
1 file changed, 17 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/14788/1
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14788
to look at the new patch set (#3).
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
---
M lib/python/impala_py_lib/helpers.py
1 file changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/14788/3
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 22:52:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5287/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:08:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Reviewed-on: http://gerrit.cloudera.org:8080/14788
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M lib/python/impala_py_lib/helpers.py
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 5
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5125/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 22:43:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py
File lib/python/impala_py_lib/helpers.py:
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43
PS1, Line 43: proc = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
Should we just use the second version always to reduce the amount of code.
I see bin/bootstrap_toolchain.py also solve this problem.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:50:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 4
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:08:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Nov 2019 18:07:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
Hello Tim Armstrong, Joe McDonnell, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/14788
to look at the new patch set (#2).
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
---
M lib/python/impala_py_lib/helpers.py
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/14788/2
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py
File lib/python/impala_py_lib/helpers.py:
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43
PS1, Line 43: proc = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> Makes sense.
I'm fine either way - seems like valid cleanup but we don't need it to fix the build failures.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:12:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14788/2/lib/python/impala_py_lib/helpers.py
File lib/python/impala_py_lib/helpers.py:
http://gerrit.cloudera.org:8080/#/c/14788/2/lib/python/impala_py_lib/helpers.py@22
PS2, Line 22: import sys
flake8: F401 'sys' imported but unused
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 21:58:40 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py
File lib/python/impala_py_lib/helpers.py:
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43
PS1, Line 43: if retcode:
> I'm fine either way - seems like valid cleanup but we don't need it to fix
Fair enough. Another patch can always be submitted for that minor cleanup.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 3
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 22:00:35 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5120/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 19:42:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py
File lib/python/impala_py_lib/helpers.py:
http://gerrit.cloudera.org:8080/#/c/14788/1/lib/python/impala_py_lib/helpers.py@43
PS1, Line 43: proc = subprocess.Popen(cmd.split(), stdout=subprocess.PIPE, stderr=subprocess.PIPE)
> Should we just use the second version always to reduce the amount of code.
Makes sense.
Afterwards, since bootstrap-toolchain.py is executed with impala-python, we could technically consolidate code a bit more by deleting that function and importing this function. Do you think I should that?
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 1
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 20:57:05 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-9157: Make helper function exec local command python 2.6 compatible
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14788 )
Change subject: IMPALA-9157: Make helper function exec_local_command python 2.6 compatible
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5124/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I928a4df9dc883e8e801a42ead14ec7875169d4ae
Gerrit-Change-Number: 14788
Gerrit-PatchSet: 2
Gerrit-Owner: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Nov 2019 22:42:49 +0000
Gerrit-HasComments: No