[GitHub] JaroslavTulach commented on a change in pull request #1122: Updating Graal.js and co. to RC12

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #1122: Updating Graal.js and co. to RC12
URL: https://github.com/apache/incubator-netbeans/pull/1122#discussion_r254716711
 
 

 ##########
 File path: ide/libs.graalsdk/test/unit/src/org/netbeans/libs/graalsdk/GraalEnginesTest.java
 ##########
 @@ -70,7 +70,7 @@ public void invokeEngineViaGeneratedScriptEngine() {
                 .append("\nnames: ").append(engineNames)
                 .append("\ntypes: ").append(types);
 
-            if (engineNames.contains("llvm")) {
+            if (engineNames.contains("LLVM")) {
 
 Review comment:
   Looks like the name changed between RC10 to RC12 to upper case. 
   
   I was thinking of doing `toLowerCase()`. On the other hand, it is just a test. If it changes again with subsequent RC, we update the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists