You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2023/01/10 08:43:39 UTC

[GitHub] [tvm] Ever-Kid opened a new pull request, #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Ever-Kid opened a new pull request, #13744:
URL: https://github.com/apache/tvm/pull/13744

   I came across this bug under python3.8.0 with error from `typing.get_args()` while trying to run testcases like `tests/python/unittest/test_tir_schedule_set_axis_separator.py::test_set_axis_separator[transform_layout_named]`
   ```
   >           if get_origin(tp) is collections.abc.Callable and res[0] is not Ellipsis:
   E           IndexError: tuple index out of range
   ```
   And the root cause here is a difference  between python3.8.0 and later version:
   ```diff
           get_args(Callable[[], T][int]) == ([], int)
       """
   -     if isinstance(tp, _GenericAlias):    // python3.8.0
   +    if isinstance(tp, _GenericAlias) and not tp._special:    // python3.8.15
           res = tp.__args__
           if get_origin(tp) is collections.abc.Callable and res[0] is not Ellipsis:
   }
   ```
   So I added it back to `python/tvm/tir/schedule/_type_checker.py`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] tvm-bot commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
tvm-bot commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1376912019

   <!---bot-comment-->
   
   Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
   
   <!--bot-comment-ccs-start-->
    * cc @Hzfengsy, @junrushao, @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
   
   <sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] sunggg commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by "sunggg (via GitHub)" <gi...@apache.org>.
sunggg commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1399113062

   Darn, let me fix this. Shouldn't be hard. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1387133374

   I rebased this branch to latest HEAD so that the CI could run properly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1387699870

   It's merged! Thanks for the PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1382640158

   @sunggg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1386521945

   @tvm-bot rerun


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1386521870

   for some reason the CI is stuck on the new pipeline added today...let me try to retrigger


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao merged pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
junrushao merged PR #13744:
URL: https://github.com/apache/tvm/pull/13744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Ever-Kid commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
Ever-Kid commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1376913187

   cc. @sunggg 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by "vinx13 (via GitHub)" <gi...@apache.org>.
vinx13 commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1399038390

   I'm getting some error in Python 3.10
   ```
     File "/usr/lib/python3.10/typing.py", line 983, in __getattr__
       return getattr(self.__origin__, attr)
   AttributeError: type object 'Callable' has no attribute '_special'
   ```
   The attribute `_special` was actually removed since Python 3.9 (they introduced `SpecialGenericAlias` instead).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] Ever-Kid commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by GitBox <gi...@apache.org>.
Ever-Kid commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1396321397

   Thanks you guys’ kindly help~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao commented on pull request #13744: [Bugfix][TIR] Fix version conflict with typing for Python 3.8.0

Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #13744:
URL: https://github.com/apache/tvm/pull/13744#issuecomment-1399102598

   Oh no. would you mind having it fixed if it’s not super hard?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org