You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "shuan1026 (via GitHub)" <gi...@apache.org> on 2026/08/28 12:59:52 UTC

[PR] HDDS-16322. ConfigurationSource.getClass loads property key instead o… [ozone]

shuan1026 opened a new pull request, #11144:
URL: https://github.com/apache/ozone/pull/11144

   ## What changes were proposed in this pull request?
   
   `ConfigurationSource.getClass` called `Class.forName(name)` on the property key after reading the configured class name into `valueString`. Implementations that do not inherit Hadoop `Configuration.getClass` therefore failed to load the configured class. Use `valueString`, matching `getClasses` and Hadoop `Configuration.getClass`.
   
   Added `getClassUsesConfiguredValueNotKey` in `TestConfigurationSource`, using `InMemoryConfigurationForTesting` (hits the default method, not Hadoop `Configuration.getClass`).
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-16322
   
   ## How was this patch tested?
   
   - `mvn -pl :hdds-config test -Dtest=TestConfigurationSource`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16322. ConfigurationSource.getClass loads property key instead of configured class name [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #11144:
URL: https://github.com/apache/ozone/pull/11144


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org


Re: [PR] HDDS-16322. ConfigurationSource.getClass loads property key instead of configured class name [ozone]

Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #11144:
URL: https://github.com/apache/ozone/pull/11144#issuecomment-5454915444

   Thanks @shuan1026 for the patch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org