[GitHub] [hudi] leesf commented on a diff in pull request #7611: [HUDI-5506] StreamWriteOperatorCoordinator may not recommit with partial uncommitted write metadata event

[GitBox <gi...@apache.org>]

leesf commented on code in PR #7611:
URL: https://github.com/apache/hudi/pull/7611#discussion_r1062445691


##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/meta/CkpMetadata.java:
##########
@@ -96,9 +97,11 @@ public void close() {
    *
    * <p>This expects to be called by the driver.
    */
-  public void bootstrap() throws IOException {
+  public void bootstrap(HoodieTableMetaClient metaClient) throws IOException {
     fs.delete(path, true);
     fs.mkdirs(path);
+    TimelineUtils.getBasicCommitTimeline(metaClient).filterPendingExcludingCompaction()

Review Comment:
   if there are multi flink jobs writing to hudi, the logic here would not solve the problem that one flink job may use other flink job pending instant. However, it would be solved in following PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org