You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "andrekef (via GitHub)" <gi...@apache.org> on 2024/05/02 13:46:05 UTC
[I] Table does not adjust `Show Total` calculation when typing to search for values via the Search Bar [superset]
andrekef opened a new issue, #28318:
URL: https://github.com/apache/superset/issues/28318
### Bug description
When utilizing the search bar functionality within a table in GitHub, the total calculation feature fails to adjust accordingly. This means that when searching for specific values within the table, the total calculation displayed does not reflect the filtered results, leading to inaccuracies in data analysis and reporting.
### How to reproduce the bug
1. Go to a Table that has a `search bar` and `Show Totals` enabled
2. Populate the table
3. Perform a search using the search bar for specific values within the table. I used a ticketID
4. Observe that the table adjusts to show only the rows matching the search criteria.
5. Check the "Show Total" calculation displayed at the bottom of the numerical column.
6. Note that the total calculation does not adjust to reflect the filtered results; it continues to display the total for all values, including those not visible due to the search filter.
### Screenshots/recordings
<img width="1262" alt="Screenshot 2024-05-02 at 9 43 04 AM" src="https://github.com/apache/superset/assets/23481484/e4b858d9-394d-49c2-8086-9a89284ead3c">
### Superset version
master / latest-dev
### Python version
3.9
### Node version
16
### Browser
Chrome
### Additional context
When I conduct cross filtering
<img width="1247" alt="Screenshot 2024-05-02 at 9 45 29 AM" src="https://github.com/apache/superset/assets/23481484/c6137890-ca0e-471d-abd1-f932d4d894cd">
, the Show Totals works
### Checklist
- [X] I have searched Superset docs and Slack and didn't find a solution to my problem.
- [X] I have searched the GitHub issue tracker and didn't find a similar bug report.
- [X] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "CoffeeWriter (via GitHub)" <gi...@apache.org>.
CoffeeWriter commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-3383301586
@rusackas @msyavuz
I received approval on Slack on Friday to work on this issue, and we’ve already started.
Could you please assign it to us? Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "kmstr87 (via GitHub)" <gi...@apache.org>.
kmstr87 commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-3395429586
@msyavuz I wanted to clear seomthing up. For the Summary Count, do we want to show the total summary of every row in the dataset, or just the total of fetched x amount of rows from the dataset when the user enables server pagination?
Ex: If the total row summary is 39k for every row in the dataset, and the user wants only 100 rows by pagination, should be still show the 39k if the search bar filter is unused, or should we only show the total of 100 rows?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "CoffeeWriter (via GitHub)" <gi...@apache.org>.
CoffeeWriter commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-3358851824
Hi @rusackas
Just to confirm: is the previous "Show totals" option now represented by the "Show summary" row in the latest Table chart?
I tested this using the quick start setup with the latest official release (Superset 5.0.0).
When using the Table chart with the "Summary" row enabled:
- Applying a Search box filter updates the displayed rows, but the Summary total does not change.
- Applying a native filter recalculates the Summary correctly.
So summary follows filters but not the search box. This also seems related to #35141, since both involve the search box not being applied consistently to other Table features (totals vs. export).
<img width="1045" height="476" alt="Image" src="https://github.com/user-attachments/assets/20142ecb-73e1-4a93-97b4-11f0063f1b45" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-2091237536
Ahh yes.. the crossfilter actually changes the data being fed to the table, so the total is calculated. The filter IN the table doesn't appear to recalculate on the fly. I'm sure it could if it had all the data, but if server pagination comes into play, that gets quite complicated.
Not sure if @justinpark 's planned migration to AG Grid would solve this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-4699309590
This should have been closed by 36083.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #28318:
URL: https://github.com/apache/superset/issues/28318#issuecomment-2737654827
This still seems to be the case, but the issue has gone silent for upward of a year. Anyone want to open a PR? If not, we may close this issue as stale in time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #28318: Table does not adjust `Show Totals` calculation when typing to search for values via the Search Bar
URL: https://github.com/apache/superset/issues/28318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org