You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Bruce Schuchardt <bs...@pivotal.io> on 2017/05/08 22:07:56 UTC
Review Request 59071: GEODE-2875 shutdown is taking as long as 20
seconds
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59071/
-----------------------------------------------------------
Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: GEODE-2875
https://issues.apache.org/jira/browse/GEODE-2875
Repository: geode
Description
-------
The band-aid fix for this problem was to reduce the wait-time on joining a thread sending shutdown messages.
This change set alters the membership manager, reviving the path of sending certain messages like ShutdownMessage over UDP instead of TCP/IP stream sockets. This avenue doesn't block trying to form point-to-point connections so the join() can complete in a short amount of time.
Diffs
-----
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e0c0ba29a5c74614d2430fb78d972e306a355845
geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 8ae66d0b6839cfbd46b479d896104f54fd11a68d
Diff: https://reviews.apache.org/r/59071/diff/1/
Testing
-------
Thanks,
Bruce Schuchardt
Re: Review Request 59071: GEODE-2875 shutdown is taking as long as 20
seconds
Posted by Hitesh Khamesra <hk...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59071/#review174234
-----------------------------------------------------------
Ship it!
Ship It!
- Hitesh Khamesra
On May 8, 2017, 10:07 p.m., Bruce Schuchardt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59071/
> -----------------------------------------------------------
>
> (Updated May 8, 2017, 10:07 p.m.)
>
>
> Review request for geode, Galen O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
>
>
> Bugs: GEODE-2875
> https://issues.apache.org/jira/browse/GEODE-2875
>
>
> Repository: geode
>
>
> Description
> -------
>
> The band-aid fix for this problem was to reduce the wait-time on joining a thread sending shutdown messages.
>
> This change set alters the membership manager, reviving the path of sending certain messages like ShutdownMessage over UDP instead of TCP/IP stream sockets. This avenue doesn't block trying to form point-to-point connections so the join() can complete in a short amount of time.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/membership/GMSJoinLeave.java e0c0ba29a5c74614d2430fb78d972e306a355845
> geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/mgr/GMSMembershipManager.java 8ae66d0b6839cfbd46b479d896104f54fd11a68d
>
>
> Diff: https://reviews.apache.org/r/59071/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bruce Schuchardt
>
>