[GitHub] csantanapr commented on a change in pull request #2383: docker pull invoker images runtimes from manifest

[gi...@git.apache.org]

csantanapr commented on a change in pull request #2383: docker pull invoker images runtimes from manifest
URL: https://github.com/apache/incubator-openwhisk/pull/2383#discussion_r122086708
 
 

 ##########
 File path: ansible/roles/invoker/tasks/deploy.yml
 ##########
 @@ -3,16 +3,40 @@
 
 - include: docker_login.yml
 
-- name: "pull action images with tag {{docker_image_tag}}"
+- name: "pull invoker images with tag {{docker_image_tag}}"
   shell: "docker pull {{docker_registry}}{{item}}:{{docker_image_tag}}"
   with_items:
     - '{{ docker_image_prefix }}/invoker'
-    - '{{ docker_image_prefix }}/dockerskeleton'
-    - '{{ docker_image_prefix }}/nodejs6action'
-    - '{{ docker_image_prefix }}/python2action'
-    - '{{ docker_image_prefix }}/python3action'
-    - '{{ docker_image_prefix }}/swift3action'
-    - '{{ docker_image_prefix }}/java8action'
+  when: docker_registry != ""
+
+- name: "pull nodejs action images with tag {{docker_image_tag}}"
+  shell: "docker pull {{docker_registry}}{{item.image.name}}:{{docker_image_tag}}"
+  with_items:
+    - "{{ runtimesManifest.runtimes.nodejs }}"
 
 Review comment:
   I worked with @dubeejw to see if there was a way to not duplicate here and be able to itirate over the dict, and then iterate over the array. we tried different combinations and were not successful.
   
   If there is a ansible ninja that would provide how to achieve this, from the docs it gives the impression is doable but we didn't found a good combination.
   http://docs.ansible.com/ansible/playbooks_loops.html
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services