You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2015/10/28 05:51:45 UTC
Review Request 39709: Added logic to ensure the during a HTTP to PID
scheduler downgrade, the previous HTTP instance gets an error message
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Repository: mesos
Description
-------
Presently, when there is a downgrade from HTTP to PID based scheduler, we did not use to send the previous HTTP scheduler instance an error message. Modified the logic to send in an error message to the old HTTP based instance.
Diffs
-----
src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
Diff: https://reviews.apache.org/r/39709/diff/
Testing
-------
make check + a test to verify HTTP to PID downgrade in another review in the chain
Thanks,
Anand Mazumdar
Re: Review Request 39709: Added logic to ensure the during a HTTP to
PID
scheduler downgrade, the previous HTTP instance gets an error message
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/#review104339
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On Oct. 28, 2015, 4:54 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39709/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Presently, when there is a downgrade from HTTP to PID based scheduler, we did not use to send the previous HTTP scheduler instance an error message. Modified the logic to send in an error message to the old HTTP based instance.
>
>
> Diffs
> -----
>
> src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
>
> Diff: https://reviews.apache.org/r/39709/diff/
>
>
> Testing
> -------
>
> make check + a test to verify HTTP to PID downgrade in another review in the chain
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 39709: Added logic to ensure the during a HTTP to
PID
scheduler downgrade, the previous HTTP instance gets an error message
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/#review104335
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 28, 2015, 4:54 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39709/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 4:54 a.m.)
>
>
> Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Presently, when there is a downgrade from HTTP to PID based scheduler, we did not use to send the previous HTTP scheduler instance an error message. Modified the logic to send in an error message to the old HTTP based instance.
>
>
> Diffs
> -----
>
> src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
>
> Diff: https://reviews.apache.org/r/39709/diff/
>
>
> Testing
> -------
>
> make check + a test to verify HTTP to PID downgrade in another review in the chain
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 39709: Added logic to ensure the during a HTTP to
PID
scheduler downgrade, the previous HTTP instance gets an error message
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 4:54 a.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Repository: mesos
Description
-------
Presently, when there is a downgrade from HTTP to PID based scheduler, we did not use to send the previous HTTP scheduler instance an error message. Modified the logic to send in an error message to the old HTTP based instance.
Diffs
-----
src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
Diff: https://reviews.apache.org/r/39709/diff/
Testing
-------
make check + a test to verify HTTP to PID downgrade in another review in the chain
Thanks,
Anand Mazumdar
Re: Review Request 39709: Added logic to ensure the during a HTTP to
PID
scheduler downgrade, the previous HTTP instance gets an error message
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39709/
-----------------------------------------------------------
(Updated Oct. 28, 2015, 4:53 a.m.)
Review request for mesos, Ben Mahler, Isabel Jimenez, and Vinod Kone.
Changes
-------
Added deps
Repository: mesos
Description
-------
Presently, when there is a downgrade from HTTP to PID based scheduler, we did not use to send the previous HTTP scheduler instance an error message. Modified the logic to send in an error message to the old HTTP based instance.
Diffs
-----
src/master/master.cpp 39ce9bc50ad0bd95ee83800a305b69670fba5ffb
Diff: https://reviews.apache.org/r/39709/diff/
Testing
-------
make check + a test to verify HTTP to PID downgrade in another review in the chain
Thanks,
Anand Mazumdar