You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/12 09:10:57 UTC

[GitHub] [flink] zhijiangW opened a new pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

zhijiangW opened a new pull request #13127:
URL: https://github.com/apache/flink/pull/13127


   
   ## What is the purpose of the change
   
   back port to release-1.10
   
   ## Brief change log
   
   ## Verifying this change
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13127:
URL: https://github.com/apache/flink/pull/13127#issuecomment-672766745


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c19c2917e94027daf40101460f0093936774ce0a",
       "status" : "SUCCESS",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/179402316",
       "triggerID" : "c19c2917e94027daf40101460f0093936774ce0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c19c2917e94027daf40101460f0093936774ce0a Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/179402316) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13127:
URL: https://github.com/apache/flink/pull/13127#issuecomment-672766745


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c19c2917e94027daf40101460f0093936774ce0a",
       "status" : "PENDING",
       "url" : "https://travis-ci.com/github/flink-ci/flink/builds/179402316",
       "triggerID" : "c19c2917e94027daf40101460f0093936774ce0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c19c2917e94027daf40101460f0093936774ce0a Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/179402316) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhijiangW commented on pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
zhijiangW commented on pull request #13127:
URL: https://github.com/apache/flink/pull/13127#issuecomment-673231369


   Reviewed in #13110 , merging!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13127:
URL: https://github.com/apache/flink/pull/13127#issuecomment-672758198


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c19c2917e94027daf40101460f0093936774ce0a (Wed Aug 12 09:17:34 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13127:
URL: https://github.com/apache/flink/pull/13127#issuecomment-672766745


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c19c2917e94027daf40101460f0093936774ce0a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c19c2917e94027daf40101460f0093936774ce0a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c19c2917e94027daf40101460f0093936774ce0a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhijiangW merged pull request #13127: [FLINK-18821][network] Fix indefinite wait in PartitionRequestClientFactory.createPartitionRequestClient

Posted by GitBox <gi...@apache.org>.
zhijiangW merged pull request #13127:
URL: https://github.com/apache/flink/pull/13127


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org