[GitHub] [beam] sadovnychyi commented on a diff in pull request #27646: Fix stateful processing using direct runner with type checks enabled

["sadovnychyi (via GitHub)" <gi...@apache.org>]

sadovnychyi commented on code in PR #27646:
URL: https://github.com/apache/beam/pull/27646#discussion_r1285245924


##########
sdks/python/apache_beam/typehints/typecheck.py:
##########
@@ -49,6 +49,13 @@ def __init__(self, dofn):
     super().__init__()
     self.dofn = dofn
 
+  def __getattribute__(self, name):

Review Comment:
   With this change the setup and teardown are no longer called in here:
   
   https://github.com/apache/beam/blob/81cd93a8640c4f3994c68e091044e8e4e7c3f081/sdks/python/apache_beam/typehints/typecheck_test.py#L101-L122
   
   Reverted for now: https://github.com/apache/beam/pull/27646/commits/81cd93a8640c4f3994c68e091044e8e4e7c3f081
   
   Any way we can proceed as is? Otherwise please suggest where to start digging, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org