You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/09/11 10:10:34 UTC

[GitHub] [apisix-dashboard] butterfly1924 commented on a diff in pull request #2538: feat: support postman collection v2 for data import

butterfly1924 commented on code in PR #2538:
URL: https://github.com/apache/apisix-dashboard/pull/2538#discussion_r967798922


##########
web/src/pages/Route/components/DataLoader/Import.tsx:
##########
@@ -73,8 +73,9 @@ const Option: React.FC<{
     case 'openapi_legacy':
       return <></>;
     case 'openapi3':
-    default:
       return <OpenAPI3 />;
+    default:
+      return <></>;

Review Comment:
   Hi, I am reopening this thread, as this breaks the CI e2e tests.
   ![image](https://user-images.githubusercontent.com/90364136/189522103-aa5b447c-94ac-4350-ab42-b34c318b3058.png)
   
   I had sent multiple mails regarding this improvement to @bzp2010 
   cc @LiteSun 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org