[GitHub] [trafficserver] bneradt commented on pull request #8885: Update to libswoc 1.3.8

[GitBox <gi...@apache.org>]

bneradt commented on PR #8885:
URL: https://github.com/apache/trafficserver/pull/8885#issuecomment-1146175463

   OK, I reproduced this locally. This is kind of funny. We check the report like so:
   
   https://github.com/apache/trafficserver-ci/blob/main/jenkins/github/rat.pipeline#L57
   
   On master, that grep produces this:
   
   ```
   $ grep '0 Unknown Licenses' RAT.txt
   30 Unknown Licenses
   ```
   
   See, it passes. The report has literally the string `0 Unknown Licenses`. Unfortunately there's a 3 in front of that.
   
   With your patch in this PR, @SolidWallOfCode , this report now shows 31 Unknown Licenses:
   
   ```
   31 Unknown Licenses
   ```
   
   Therefore the grep fails.
   
   Clearly we need to update CI to check more precisely. In the meantime, I'm not sure what to do about these licenses. Do we have to officially vet this with someone in Apache?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org