You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@jackrabbit.apache.org by GitBox <gi...@apache.org> on 2020/06/01 07:33:52 UTC

[GitHub] [jackrabbit-oak] Vinod-holani commented on pull request #231: GRANITE-30089

Vinod-holani commented on pull request #231:
URL: https://github.com/apache/jackrabbit-oak/pull/231#issuecomment-636666639


   > It would be good to understand why we don't have a failing test for this (and add that first).
   
   We do have test case for this. But by default that test class is disabled. I enabled them and saw test case was failing but silently so I have updated the test class with fix and also rethrowing caught exception. For disabled test case See [0]
   [0] : https://github.com/apache/jackrabbit-oak/blob/trunk/oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentStorePerformanceTest.java#L43
   
   Shouldn't we enable this test class by default also? WDYT?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org