You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/04/05 20:50:37 UTC
[GitHub] madlib pull request #255: MLP: Remove source table dependency for predicting...
GitHub user njayaram2 opened a pull request:
https://github.com/apache/madlib/pull/255
MLP: Remove source table dependency for predicting regression models
JIRA: MADLIB-1223
We were getting the type of the dependent variable from the
input table to know if it was an array or not. With this commit, we now get
this information from the model summary table.
We also had to add a column in the minibatch preprocessor summary table
called `dependent_vartype` in order to get the dependent type in the mlp
code for minibatching.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/mlp/remove-training-data-dependency
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/255.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #255
----
commit a17a54a4bf4ce0f9b256ccaf32a8a2f61b2c4f18
Author: Nandish Jayaram <nj...@...>
Date: 2018-04-03T21:32:03Z
MLP: Remove source table dependency for predicting regression models
JIRA: MADLIB-1223
We were getting the type of the dependent variable from the
input table to know if it was an array or not. With this commit, we now get
this information from the model summary table.
We also had to add a column in the minibatch preprocessor summary table
called `dependent_vartype` in order to get the dependent type in the mlp
code for minibatching.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
commit 16a06924dcee1ba273c5e4a49f81ee48cda778cd
Author: Nandish Jayaram <nj...@...>
Date: 2018-04-04T21:42:38Z
MLP: Fix bug in array dep var for regression
MLP training for regression fails if the dependent var type is an array.
This is because the variable dependent_varname was not updated to
reflect the new column created in the standardized table. This commit
fixes that issue.
Co-authored-by: Nikhil Kak <nk...@pivotal.io>
----
---
[GitHub] madlib issue #255: MLP: Remove source table dependency for predicting regres...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/255
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/423/
---
[GitHub] madlib issue #255: MLP: Remove source table dependency for predicting regres...
Posted by fmcquillan99 <gi...@git.apache.org>.
Github user fmcquillan99 commented on the issue:
https://github.com/apache/madlib/pull/255
LGTM, see https://issues.apache.org/jira/browse/MADLIB-1223 for tests i ran
---
[GitHub] madlib issue #255: MLP: Remove source table dependency for predicting regres...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/255
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/430/
---
[GitHub] madlib pull request #255: MLP: Remove source table dependency for predicting...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/255
---