Re: cvs commit: apache-2.0/src/main http_core.c

[Jeff Trawick <tr...@bellsouth.net>]

stoddard@locus.apache.org writes:

> stoddard    00/10/04 12:11:05
> 
>   Modified:    src/main http_core.c
>   Log:
>   Take another shot at reimplementing core_output_filter. This implementation buffers
>   brigades across multiple calls until MAX_IOVEC_TO_WRITE or
>   MIN_SIZE_TO_WRITE thresholds are hit. This implementation does not attempt
>   to coalesce bytes. Moving a bit further down the filter learning curve...

Warning!  A cgi request in a regression script looped forever with
this code.  I'm looking into it now but I don't know if I'll have time
to solve it.

-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...

Re: cvs commit: apache-2.0/src/main http_core.c

[Jeff Trawick <tr...@bellsouth.net>]

Jeff Trawick <tr...@bellsouth.net> writes:

> stoddard@locus.apache.org writes:
> 
> > stoddard    00/10/04 12:11:05
> > 
> >   Modified:    src/main http_core.c
> >   Log:
> >   Take another shot at reimplementing core_output_filter. This implementation buffers
> >   brigades across multiple calls until MAX_IOVEC_TO_WRITE or
> >   MIN_SIZE_TO_WRITE thresholds are hit. This implementation does not attempt
> >   to coalesce bytes. Moving a bit further down the filter learning curve...
> 
> Warning!  A cgi request in a regression script looped forever with
> this code.  I'm looking into it now but I don't know if I'll have time
> to solve it.

I'm pretty darn sure that the problem is in writev_it_all() in the
logic to recover from a partial write...  That wasn't touched with
this commit (sorry!)...  I guess it is called a little differently
now...  (back to the mine)
-- 
Jeff Trawick | trawick@ibm.net | PGP public key at web site:
     http://www.geocities.com/SiliconValley/Park/9289/
          Born in Roswell... married an alien...