You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2019/07/26 23:59:00 UTC

[impala] 02/02: IMPALA-8794: Skipping testPiggyback* in Hive 3 builds

This is an automated email from the ASF dual-hosted git repository.

tarmstrong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git

commit 20b5b1f13a5cdafd793014c81ae3c3b4e5568d06
Author: Csaba Ringhofer <cs...@cloudera.com>
AuthorDate: Thu Jul 25 21:02:02 2019 +0200

    IMPALA-8794: Skipping testPiggyback* in Hive 3 builds
    
    The tests turned out to be very flaky with Hive 3. Skipping them
    for now to make the builds green.
    
    Change-Id: Ice8f52caa20021ad9e36cbebe62a2bb247a4273c
    Reviewed-on: http://gerrit.cloudera.org:8080/13920
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 .../impala/catalog/local/CatalogdMetaProviderTest.java     | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java b/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
index 60db091..c4276d2 100644
--- a/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
+++ b/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java
@@ -39,6 +39,7 @@ import org.apache.impala.catalog.local.MetaProvider.TableMetaRef;
 import org.apache.impala.common.Pair;
 import org.apache.impala.service.FeSupport;
 import org.apache.impala.service.FrontendProfile;
+import org.apache.impala.testutil.TestUtils;
 import org.apache.impala.thrift.TBackendGflags;
 import org.apache.impala.thrift.TCatalogObject;
 import org.apache.impala.thrift.TCatalogObjectType;
@@ -47,6 +48,7 @@ import org.apache.impala.thrift.TNetworkAddress;
 import org.apache.impala.thrift.TRuntimeProfileNode;
 import org.apache.impala.thrift.TTable;
 import org.apache.impala.util.ListMap;
+import org.junit.Assume;
 import org.junit.Test;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -251,11 +253,21 @@ public class CatalogdMetaProviderTest {
 
   @Test
   public void testPiggybackSuccess() throws Exception {
+    // TODO: investigate the cause of flakiness (IMPALA-8794)
+    Assume.assumeTrue(
+        "Skipping this test because it is flaky with Hive3",
+        TestUtils.getHiveMajorVersion() == 2);
+
     doTestPiggyback(/*success=*/true);
   }
 
   @Test
   public void testPiggybackFailure() throws Exception {
+    // TODO: investigate the cause of flakiness (IMPALA-8794)
+    Assume.assumeTrue(
+        "Skipping this test because it is flaky with Hive3",
+        TestUtils.getHiveMajorVersion() == 2);
+
     doTestPiggyback(/*success=*/false);
   }
 
@@ -319,4 +331,4 @@ public class CatalogdMetaProviderTest {
     }
   }
 
-}
\ No newline at end of file
+}