You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Dave Thompson (Jira)" <ji...@apache.org> on 2023/03/20 13:26:00 UTC

[jira] [Closed] (DAFFODIL-2799) Separate "lint" checks from "OS/JDK" matrix checks

     [ https://issues.apache.org/jira/browse/DAFFODIL-2799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Thompson closed DAFFODIL-2799.
-----------------------------------

Verified the specified commit (commit e14f6d07114249f373c430d2beb26103be7fe9ef) is included in the latest pull from the daffodil repository.

Verified, via review, changes identified in the commit comment were implemented. 

Verified on the following sites that the lint checks were moved to a separate job:

 - https://github.com/apache/daffodil/pull/984/checks
 - https://github.com/apache/daffodil/actions/runs/4441045220/

> Separate "lint" checks from "OS/JDK" matrix checks
> --------------------------------------------------
>
>                 Key: DAFFODIL-2799
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-2799
>             Project: Daffodil
>          Issue Type: Improvement
>          Components: Infrastructure
>    Affects Versions: 3.5.0
>            Reporter: John Interrante
>            Priority: Minor
>             Fix For: 3.5.0
>
>
> Contributors must feel discouraged to make a PR change and see 3 out of 6 matrix jobs fail across the board.  Let's move the Rat, OSGi, scalafmt, and sonarcloud checks which aren't OS-specific or JDK-specific into their own lint job inside main.yml separate from the OS/JDK checks.  Separating the lint checks would also let the OS/JDK matrix jobs finish 1-2 minutes quicker.  In order to give contributors and reviewers as much information as possible about a PR, let's configure the new job to always run all the lint checks even if one lint check fails and always run all the OS/JDK checks even if any of the lint checks fail since we still want to know whether all the OS/JDK tests pass as well as whether all the lint checks pass.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)