You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/15 11:09:19 UTC

[GitHub] [flink] manbuyun opened a new pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey 

manbuyun opened a new pull request #12169:
URL: https://github.com/apache/flink/pull/12169


   ## What is the purpose of the change
   
   We need to add some custom labels on Prometheus, so we can query by them.
   Now we can add jobName\groupingKey to PrometheusPushGatewayReporter in version 1.10, but not in PrometheusReporter.
   Can we add AbstractPrometheusReporter#addDimension method to support this, so they will be no differences except for the metrics exposing mechanism pulling/pushing.
   
   ## Brief change log
   
   - AbstractPrometheusReporter unify parseLabels method
   - AbstractPrometheusReporter add resolveDimensions method into notifyOfAddedMetric
   
   ## Verifying this change
   
   This change is already covered by existing tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] manbuyun commented on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
manbuyun commented on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629618713


   @flinkbot run travis


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
zentol commented on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-637460924


   This can be implemented more generically by configuring these for the entire metric system and adding these labels as variables into the root metric groups.
   This would then _just work_ for all reporters.
   
   I'd suggest to close this PR and get back to the drawing board.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629176989


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 (Fri May 15 11:12:17 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-17495).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol closed pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
zentol closed pull request #12169:
URL: https://github.com/apache/flink/pull/12169


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1532",
       "triggerID" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5d47c27ad3e586414f7f4ad2623acd477b7a6644 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1532) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1532",
       "triggerID" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424) 
   * 5d47c27ad3e586414f7f4ad2623acd477b7a6644 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1532) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5d47c27ad3e586414f7f4ad2623acd477b7a6644",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424) 
   * 5d47c27ad3e586414f7f4ad2623acd477b7a6644 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12169: [FLINK-17495][metrics][prometheus]Add custom labels on PrometheusReporter like PrometheusPushGatewayReporter's groupingKey

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12169:
URL: https://github.com/apache/flink/pull/12169#issuecomment-629195529


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424",
       "triggerID" : "9e55eae7a9819ab59c05e4c27d3d4992246b75f4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 9e55eae7a9819ab59c05e4c27d3d4992246b75f4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1424) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org